You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/03/24 19:32:18 UTC
[GitHub] [tinkerpop] spmallette opened a new pull request #1268:
TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
spmallette opened a new pull request #1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
URL: https://github.com/apache/tinkerpop/pull/1268
https://issues.apache.org/jira/browse/TINKERPOP-2350
We weren't deep copying bytecode before. Added a test to verify things are working as expected and manually tested the failing example in the JIRA:
```text
>>> g = traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
>>> t0 = g.V().hasLabel('x')
>>> t0
[['V'], ['hasLabel', 'x']]
>>> t1 = t0.clone()
>>> t1
[['V'], ['hasLabel', 'x']]
>>> t1.has('name','y')
[['V'], ['hasLabel', 'x'], ['has', 'name', 'y']]
>>> t0
[['V'], ['hasLabel', 'x']]
>>>
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette merged pull request #1268: TINKERPOP-2350
Fixed bug in Traversal.clone() in gremlin-python
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
URL: https://github.com/apache/tinkerpop/pull/1268
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1268: TINKERPOP-2350
Fixed bug in Traversal.clone() in gremlin-python
Posted by GitBox <gi...@apache.org>.
spmallette commented on issue #1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
URL: https://github.com/apache/tinkerpop/pull/1268#issuecomment-603772241
I'll modify the ticket to include .NET 🤦♂ - we can re-use it for your separate PR. thanks for testing/fixing in .NET
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] FlorianHockmann commented on a change in pull request
#1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on a change in pull request #1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
URL: https://github.com/apache/tinkerpop/pull/1268#discussion_r397925744
##########
File path: gremlin-python/src/main/jython/tests/process/test_traversal.py
##########
@@ -82,3 +82,22 @@ def test_anonymous_traversal(self):
assert 0 == len(bytecode.bindings.keys())
assert 0 == len(bytecode.source_instructions)
assert 0 == len(bytecode.step_instructions)
+
+ def test_clone_traversal(self):
+ g = Graph().traversal()
Review comment:
(nitpick) Any reason not to use the anonymous traversal source here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1268:
TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on issue #1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python
URL: https://github.com/apache/tinkerpop/pull/1268#issuecomment-603754037
I just checked this for .NET and we have the same bug there. Not sure if you want to use the same JIRA ticket / PR for .NET. Otherwise, I can also create a PR and/or ticket for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services