You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/02/06 00:18:23 UTC
[Bug 6323] New: Consider removing RATWARE_GECKO_BUILD
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Summary: Consider removing RATWARE_GECKO_BUILD
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: antispam@khopis.com
CC: jm@jmason.org, sidney@sidney.com, kmcgrail@pccc.com,
jgmyers@proofpoint.com, antispam@khopis.com,
abillington@tetragonpublishing.com
Depends on: 6305
+++ This bug was initially created as a clone of Bug #6305 +++
RATWARE_GECKO_BUILD is scored 0 on the trunk. Presumably, this means that it
is not tested despite the entry in http://ruleqa.spamassassin.org
I'd like to remove it from the active ruleset and return it to testing for
review. I suspect that it will not be worth the Y2K30 issue its present form
introduces.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #7 from Kevin A. McGrail <km...@pccc.com> 2010-03-03 18:43:25 UTC ---
(In reply to comment #6)
> That's 4 votes already, including Adam's implied vote. With 3 needed, AFAIK. :)
>
> Anyway, here's yet another... +1
I didn't count Adam's because he's not a PMC or committer, I thought. At least
according to the credits page...
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[just do it] Consider |Consider removing
|removing |RATWARE_GECKO_BUILD
|RATWARE_GECKO_BUILD |
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [just do it] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|security |
Component|Security |Libraries
AssignedTo|security@spamassassin.apach |dev@spamassassin.apache.org
|e.org |
--- Comment #16 from Karsten Bräckelmann <gu...@rudersport.de> 2010-03-23 17:42:21 UTC ---
Moving back off of Security, which got changed by accident during the mass
Target Milestone move.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Re: Voting
Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 3/3/2010 3:06 PM, Karsten Bräckelmann wrote:
>> --- Comment #8 from Adam Katz<an...@khopis.com> 2010-03-03 19:51:18 UTC ---
>>
>>> I didn't count Adam's because he's not a PMC or committer, I thought. At least
>>> according to the credits page...
>>>
>> I'm a committer, but I don't like voting for something I've nominated.
>>
> http://wiki.apache.org/spamassassin/VotingProcedure
> http://wiki.apache.org/spamassassin/DevelopmentMode
>
> "The author of a patch is allowed to vote as long as they're a
> committer. Typically, if a committer uploaded the patch, it's assumed
> they're implicitly voting +1 on their own patch, unless otherwise
> specified."
>
> Extends to any proposition IMHO. You don't have to vote if you nominate
> it. You would not have done so, if you're against it, no? :)
>
>
> Oh, and Bugzilla is not a good place for rather general discussions, but
> a tool to track issues and their progress.
>
>
>
Thanks!
Voting (was: Bug 6323)
Posted by Karsten Bräckelmann <gu...@rudersport.de>.
> --- Comment #8 from Adam Katz <an...@khopis.com> 2010-03-03 19:51:18 UTC ---
> > I didn't count Adam's because he's not a PMC or committer, I thought. At least
> > according to the credits page...
>
> I'm a committer, but I don't like voting for something I've nominated.
http://wiki.apache.org/spamassassin/VotingProcedure
http://wiki.apache.org/spamassassin/DevelopmentMode
"The author of a patch is allowed to vote as long as they're a
committer. Typically, if a committer uploaded the patch, it's assumed
they're implicitly voting +1 on their own patch, unless otherwise
specified."
Extends to any proposition IMHO. You don't have to vote if you nominate
it. You would not have done so, if you're against it, no? :)
Oh, and Bugzilla is not a good place for rather general discussions, but
a tool to track issues and their progress.
--
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #8 from Adam Katz <an...@khopis.com> 2010-03-03 19:51:18 UTC ---
> I didn't count Adam's because he's not a PMC or committer, I thought. At least
> according to the credits page...
I'm a committer, but I don't like voting for something I've nominated.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Adam Katz <an...@khopis.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 more votes |
--- Comment #5 from Adam Katz <an...@khopis.com> 2010-03-03 17:59:53 UTC ---
off-by-one. vote passes.
I'm not expert in rule removal, so I'll let somebody else act on this.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jpf321@gmail.com
--- Comment #18 from Karsten Bräckelmann <gu...@rudersport.de> 2010-04-01 12:26:11 UTC ---
*** Bug 6391 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2010-03-03 17:50:56 UTC ---
+1 for removal
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #10 from Sidney Markowitz <si...@sidney.com> 2010-03-03 21:11:07 UTC ---
(in reply to comment #8 and comment #9)
Yes, the policy for anything covered under R-T-C is three committer votes, with
the act by a committer of proposing a patch and being willing to commit it
implying that person's vote. If you aren't comfortable committing your patch
until you get more feedback or another vote or until any other condition is
met, you can always say so and then your position on it is explicit instead of
implied.
In practice it means that when you propose a patch under R-T-C you only have to
get two other votes before you can commit it, but nobody will force you to vote
for the patch or to commit it before you are ready to.
By the way, +1 for removing the rule :)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [just do it] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #13 from Mark Martinec <Ma...@ijs.si> 2010-03-11 18:51:52 UTC ---
trunk:
Bug 6323: Consider removing RATWARE_GECKO_BUILD
Sending rules/20_ratware.cf
Sending rules/30_text_de.cf
Sending rules/30_text_nl.cf
Sending rules/50_scores.cf
Sending rulesrc/10_force_active.cf
Transmitting file data .....
Committed revision 921983.
Is this it? Anything else needs to be done?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #9 from Kevin A. McGrail <km...@pccc.com> 2010-03-03 20:57:42 UTC ---
My apologies. Sorry. I checked the credits file because I thought you were but
then figured my memory was wrong. ;-)
You should see http://wiki.apache.org/spamassassin/BecomingCommitter and add
your name to the CREDITS file.
BTW, your nomination counts as a de facto vote yes to my knowledge
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #6 from Karsten Bräckelmann <gu...@rudersport.de> 2010-03-03 18:01:42 UTC ---
That's 4 votes already, including Adam's implied vote. With 3 needed, AFAIK. :)
Anyway, here's yet another... +1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #1 from Justin Mason <jm...@jmason.org> 2010-03-02 11:21:43 UTC ---
go right ahead. +1 for removal
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs two more votes |needs 1 more votes
--- Comment #4 from Kevin A. McGrail <km...@pccc.com> 2010-03-03 17:55:14 UTC ---
+1 KAM
That's 3 votes from Justin, Myself & Mark. Doesn't that mean the count is off
by one and this is now ready to go? Or is it 4 votes?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [just do it] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Warren Togami <wa...@togami.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[review] Consider removing |[just do it] Consider
|RATWARE_GECKO_BUILD |removing
| |RATWARE_GECKO_BUILD
--- Comment #11 from Warren Togami <wa...@togami.com> 2010-03-11 03:29:55 UTC ---
What is blocking this?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [just do it] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #12 from Mark Martinec <Ma...@ijs.si> 2010-03-11 11:21:47 UTC ---
> What is blocking this?
Nothing, AFICT.
Just someone needs to get his hands dirty and do it.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [review] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Adam Katz <an...@khopis.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Consider removing |[review] Consider removing
|RATWARE_GECKO_BUILD |RATWARE_GECKO_BUILD
Status Whiteboard| |needs two more votes
--- Comment #2 from Adam Katz <an...@khopis.com> 2010-03-03 17:46:11 UTC ---
Well if we already have one vote for it, let's make the review official.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.3.1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [just do it] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Libraries |Rules
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [just do it] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
Adam Katz <an...@khopis.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #17 from Adam Katz <an...@khopis.com> 2010-03-31 16:00:28 UTC ---
(In reply to comment #14)
> Should it be committed to 3.3 too?
Yes, and it appears already done:
$ sa_update_grep() {
ver=`echo $1 |sed -r 's/([0-9])\.([0-9])\.([0-9])/\3.\2.\1/'`
file=`host -t txt $ver.updates.spamassassin.org |egrep -o '[0-9]{4,}'`
wget -qO - http://www.sa-update.pccc.com/$file.tar.gz |zgrep -a "$2"
}
$ sa_update_grep 3.3.0 'score.*GECKO'
$ sa_update_grep 3.2.0 'score.*GECKO'
50_scores.cf:score RATWARE_GECKO_BUILD 0 # n=0 n=1 n=2 n=3
$
$ cd ~/sa/trunk
$ svn update
At revision 929592.
$ grep -r GECKO rules/*cf
$
(all of 3.3.x shares the same update file, ditto for 3.2.x)
So it's zeroed on 3.2.x and removed from 3.3.x and the trunk.
Closing.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6323] [just do it] Consider removing RATWARE_GECKO_BUILD
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6323
--- Comment #14 from Warren Togami <wa...@togami.com> 2010-03-11 19:51:30 UTC ---
Should it be committed to 3.3 too?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.