You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/27 18:56:44 UTC
[GitHub] [geode] mkevo opened a new pull request #7320: GEODE-9969: Fix unescaping the region name with underscore
mkevo opened a new pull request #7320:
URL: https://github.com/apache/geode/pull/7320
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7320: GEODE-9969: Fix unescaping the region name with underscore
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #7320:
URL: https://github.com/apache/geode/pull/7320#issuecomment-1042796222
Hi @dschneider-pivotal,
Can you please re-review this PR?
BR,
Mario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7320: GEODE-9969: Fix unescaping the region name with underscore
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #7320:
URL: https://github.com/apache/geode/pull/7320#issuecomment-1060318417
Hi @dschneider-pivotal,
Can you please add your review on this?
The same PR as you approved before (#7282) with replacing double quotes with single quotes to pass tests on windows.
BR,
Mario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7320: GEODE-9969: Fix unescaping the region name with underscore
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #7320:
URL: https://github.com/apache/geode/pull/7320#issuecomment-1063795482
Hi @dschneider-pivotal, @gesterzhou, @jchen21, @upthewaterspout,
Can someone add a review for the files you are CODEOWNER?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7320: GEODE-9969: Fix unescaping the region name with underscore
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #7320:
URL: https://github.com/apache/geode/pull/7320#issuecomment-1025656110
Hi @dschneider-pivotal,
This is the same PR as the one you approved before([#7282](https://github.com/apache/geode/pull/7282)) with the minor change, replacing double quotes with a single quote to pass test on the windows.
Can you please approved this so we can merge it?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mkevo edited a comment on pull request #7320: GEODE-9969: Fix unescaping the region name with underscore
Posted by GitBox <gi...@apache.org>.
mkevo edited a comment on pull request #7320:
URL: https://github.com/apache/geode/pull/7320#issuecomment-1025656110
Hi @dschneider-pivotal,
This is the same PR as the one you approved before([#7282](https://github.com/apache/geode/pull/7282)) with the minor change, replacing double quotes with a single quote to pass test on the windows.
Can you please approve this so we can merge it?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7320: GEODE-9969: Fix unescaping the region name with underscore
Posted by GitBox <gi...@apache.org>.
mivanac merged pull request #7320:
URL: https://github.com/apache/geode/pull/7320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org