You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/17 07:32:17 UTC
[GitHub] [apisix] bisakhmondal opened a new pull request #6128: docs: add vault support into readme
bisakhmondal opened a new pull request #6128:
URL: https://github.com/apache/apisix/pull/6128
Signed-off-by: Bisakh Mondal <bi...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
#6118
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #6128: docs: add vault support into readme
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #6128:
URL: https://github.com/apache/apisix/pull/6128#discussion_r785787745
##########
File path: README.md
##########
@@ -116,6 +116,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- [CORS](docs/en/latest/plugins/cors.md) Enable CORS(Cross-origin resource sharing) for your API.
- [URI Blocker](docs/en/latest/plugins/uri-blocker.md): Block client request by URI.
- [Request Validator](docs/en/latest/plugins/request-validation.md)
+ - [HashiCorp Vault](docs/en/latest/plugins/jwt-auth.md#enable-jwt-auth-with-vault-compatibility): Support secret management solution for accessing secrets from Vault secure storage backed in a low trust environment. Currently, RS256 keys (public-private keypairs) or secret keys can be linked from vault in [jwt-auth](docs/en/latest/plugins/jwt-auth.md) authentication plugin.
Review comment:
Thanks. Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6128: docs: add vault support into readme
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6128:
URL: https://github.com/apache/apisix/pull/6128#discussion_r785736760
##########
File path: README.md
##########
@@ -116,6 +116,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- [CORS](docs/en/latest/plugins/cors.md) Enable CORS(Cross-origin resource sharing) for your API.
- [URI Blocker](docs/en/latest/plugins/uri-blocker.md): Block client request by URI.
- [Request Validator](docs/en/latest/plugins/request-validation.md)
+ - [HashiCorp Vault](docs/en/latest/plugins/jwt-auth.md#enable-jwt-auth-with-vault-compatibility): Support secret management solution for accessing secrets from Vault secure storage backed in a low trust environment. Currently, RS256 keys (public-private keypairs) or secret keys can be linked from vault in [jwt-auth](docs/en/latest/plugins/jwt-auth.md) authentication plugin.
Review comment:
I think this feature should be under **OPS friendly**?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6128: docs: add vault support into readme
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6128:
URL: https://github.com/apache/apisix/pull/6128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org