You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by smanvi-pivotal <gi...@git.apache.org> on 2016/06/16 04:12:52 UTC
[GitHub] incubator-geode pull request #161: GEODE-1549: Correct "Help" hyperlink in p...
GitHub user smanvi-pivotal opened a pull request:
https://github.com/apache/incubator-geode/pull/161
GEODE-1549: Correct "Help" hyperlink in pulse
The Help hyperlink in the Pulse UI was incorrect.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smanvi-pivotal/incubator-geode feature/GEODE-1549
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
----
commit 6609989808b67c59b07f9c1677e12c379b716470
Author: Srikanth Manvi <sr...@gmail.com>
Date: 2016-06-16T03:13:58Z
GEODE-1549: Correct "Help" hyperlink in pulse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #161: GEODE-1549: Correct "Help" hyperlink in p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/161
I'll pull this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/161
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by smanvi-pivotal <gi...@git.apache.org>.
Github user smanvi-pivotal commented on the issue:
https://github.com/apache/incubator-geode/pull/161
@kirklund , should I just submit a new commit and a new pull request with the correction ? Do I need to do anything with this pull request ? like discarding or something ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by smanvi-pivotal <gi...@git.apache.org>.
Github user smanvi-pivotal commented on the issue:
https://github.com/apache/incubator-geode/pull/161
Thanks for pointing out @sboorlagadda and @kirklund. Will make the change. Was not aware that there was separate documentation for Geode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by sboorlagadda <gi...@git.apache.org>.
Github user sboorlagadda commented on the issue:
https://github.com/apache/incubator-geode/pull/161
@smanvi-pivotal Shouldn`t we refer geode docs rather than gemfire?
Eg: http://**geode.**docs.pivotal.io/**docs**/tools_modules/pulse/chapter_overview.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by sboorlagadda <gi...@git.apache.org>.
Github user sboorlagadda commented on the issue:
https://github.com/apache/incubator-geode/pull/161
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/161
Changes look good. I'll pull this in to commit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by sboorlagadda <gi...@git.apache.org>.
Github user sboorlagadda commented on the issue:
https://github.com/apache/incubator-geode/pull/161
@smanvi-pivotal The PR gets updated automatically when you push the new commit on your feature branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #161: GEODE-1549: Correct "Help" hyperlink in pulse
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/161
@sboorlagadda Yes, I missed that. Thanks Sai! @smanvi-pivotal can you please change the links to point at corresponding pages under http://geode.docs.pivotal.io/docs/tools_modules/pulse/chapter_overview.html? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---