You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/05/29 07:12:51 UTC
[GitHub] [camel] gnodet opened a new pull request #3870: Junit5
gnodet opened a new pull request #3870:
URL: https://github.com/apache/camel/pull/3870
[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #3870:
URL: https://github.com/apache/camel/pull/3870#issuecomment-642239144
@davsclaus yes, the tests are fine, I'll push the migrated tests to master tomorrow and keep this PR for other experiments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3870:
URL: https://github.com/apache/camel/pull/3870#issuecomment-642203671
@gnodet are you getting to a point where for example all the core tests has been migrated. I think we need to get this merged before the 3.4.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #3870:
URL: https://github.com/apache/camel/pull/3870#issuecomment-662333189
Outdated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet closed pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
gnodet closed pull request #3870:
URL: https://github.com/apache/camel/pull/3870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3870:
URL: https://github.com/apache/camel/pull/3870#issuecomment-636119467
Whoa is this a big migration camel-core from junit 4 to 5 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #3870:
URL: https://github.com/apache/camel/pull/3870#issuecomment-636133626
Yes, but
> Whoa is this a big migration camel-core from junit 4 to 5 ?
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] omarsmak commented on pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #3870:
URL: https://github.com/apache/camel/pull/3870#issuecomment-662320392
@gnodet what's the state of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet edited a comment on pull request #3870: Junit5
Posted by GitBox <gi...@apache.org>.
gnodet edited a comment on pull request #3870:
URL: https://github.com/apache/camel/pull/3870#issuecomment-636133626
> Whoa is this a big migration camel-core from junit 4 to 5 ?
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org