You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by b789 <gi...@git.apache.org> on 2015/10/01 14:17:12 UTC
[GitHub] metamodel pull request: Fix excel decimal formatter
GitHub user b789 opened a pull request:
https://github.com/apache/metamodel/pull/50
Fix excel decimal formatter
Fix to solve the problem of having the decimal values from excel truncated to two digits.
https://issues.apache.org/jira/browse/METAMODEL-190
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/b789/metamodel 4.0.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit 84d5a9f97dc45d37288324f0100879136317685e
Author: davideconsonni <da>
Date: 2015-10-01T12:14:31Z
Fix excel decimal formatter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix excel decimal formatter
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/50#issuecomment-144962195
hmm something's odd here. You PR is suggesting we add this to the 4.0.x branch while it should probably do it on the master branch.
If I add the patch to my master branch then my build fails with the following issue:
```
Failed tests:
FormatHelperTest.testNumberFormat:32 expected:<987643.21[]> but was:<987643.21[3456343]>
Tests run: 281, Failures: 1, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] MetaModel .......................................... SUCCESS [ 4.185 s]
[INFO] MetaModel core API ................................. FAILURE [ 13.168 s]
[INFO] MetaModel module for collection and POJO-based DataContexts. SKIPPED
[INFO] MetaModel module for fixed width value files ....... SKIPPED
[INFO] MetaModel module for Excel spreadsheets ............ SKIPPED
[INFO] MetaModel module for comma-separated value (CSV) files SKIPPED
[INFO] MetaModel module for JSON files .................... SKIPPED
[INFO] MetaModel module for XML files ..................... SKIPPED
[INFO] MetaModel module for relational JDBC databases ..... SKIPPED
[INFO] MetaModel module for Elasticsearch analytics engine SKIPPED
[INFO] MetaModel module for Apache Hadoop, HDFS, YARN integration SKIPPED
[INFO] MetaModel module for Apache HBase .................. SKIPPED
[INFO] MetaModel module for Apache Cassandra database ..... SKIPPED
[INFO] MetaModel module for MongoDB databases ............. SKIPPED
[INFO] MetaModel module for CouchDB databases ............. SKIPPED
[INFO] MetaModel module for OpenOffice.org database files . SKIPPED
[INFO] MetaModel module for Salesforce.com ................ SKIPPED
[INFO] MetaModel module for SugarCRM ...................... SKIPPED
[INFO] MetaModel full package, including DataContext factories SKIPPED
[INFO] MetaModel module for Spring enabled configuration .. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix excel decimal formatter
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/50#issuecomment-144712112
Hmm Travis build failed, but it seems to be some issue on the build server ...
Did you run the full build after your change? I could imagine that changing this in the FormatHelper could also have effects in other places than the Excel module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix excel decimal formatter
Posted by b789 <gi...@git.apache.org>.
Github user b789 commented on the pull request:
https://github.com/apache/metamodel/pull/50#issuecomment-144715362
Launching mvn compile in my local fork master compile fine and 4.0.x fails with: Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check (rat-verify) on project MetaModel: Too many unapproved licenses.
After the change the situation still the same.
Sorry if i made something wrong but i'm not used to this kind of things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix excel decimal formatter
Posted by b789 <gi...@git.apache.org>.
Github user b789 commented on the pull request:
https://github.com/apache/metamodel/pull/50#issuecomment-145234409
You're right i messed up a bit, i'll close this pull request and open another one on the master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix excel decimal formatter
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/50#issuecomment-144834668
no need to worry about 4.0.x branch :)
I'll do the build myself also tomorrow. If everything is fine, +1 from me and I'll merge unless anyone else objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix excel decimal formatter
Posted by b789 <gi...@git.apache.org>.
Github user b789 closed the pull request at:
https://github.com/apache/metamodel/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---