You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/03/04 16:37:55 UTC
(superset) 23/28: fix(sqllab): Missing empty query result state (#27313)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f0632405c237a0b32031d8aa827bb38d789d6bd3
Author: JUST.in DO IT <ju...@airbnb.com>
AuthorDate: Fri Mar 1 10:08:07 2024 -0800
fix(sqllab): Missing empty query result state (#27313)
(cherry picked from commit ae8ec9c2b48788b275621e16d434fb33f95dc91a)
---
.../src/SqlLab/components/SouthPane/Results.tsx | 2 +-
.../src/SqlLab/components/SouthPane/SouthPane.test.tsx | 13 +++++++++++++
.../src/SqlLab/components/SouthPane/index.tsx | 14 ++++++--------
3 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/superset-frontend/src/SqlLab/components/SouthPane/Results.tsx b/superset-frontend/src/SqlLab/components/SouthPane/Results.tsx
index b5167be61f..44e92ceaf9 100644
--- a/superset-frontend/src/SqlLab/components/SouthPane/Results.tsx
+++ b/superset-frontend/src/SqlLab/components/SouthPane/Results.tsx
@@ -29,7 +29,7 @@ import { LOCALSTORAGE_MAX_QUERY_AGE_MS } from '../../constants';
const EXTRA_HEIGHT_RESULTS = 8; // we need extra height in RESULTS tab. because the height from props was calculated based on PREVIEW tab.
type Props = {
- latestQueryId: string;
+ latestQueryId?: string;
height: number;
displayLimit: number;
defaultQueryLimit: number;
diff --git a/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.test.tsx b/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.test.tsx
index c978a4ca32..2e66c2f33c 100644
--- a/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.test.tsx
+++ b/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.test.tsx
@@ -123,6 +123,19 @@ test('should render offline when the state is offline', async () => {
expect(getByText(STATUS_OPTIONS.offline)).toBeVisible();
});
+test('should render empty result state when latestQuery is empty', () => {
+ const { getAllByRole } = render(
+ <SouthPane {...mockedProps} latestQueryId={undefined} />,
+ {
+ useRedux: true,
+ initialState: mockState,
+ },
+ );
+
+ const resultPanel = getAllByRole('tabpanel')[0];
+ expect(resultPanel).toHaveTextContent('Run a query to display results');
+});
+
test('should render tabs for table preview queries', () => {
const { getAllByRole } = render(<SouthPane {...mockedProps} />, {
useRedux: true,
diff --git a/superset-frontend/src/SqlLab/components/SouthPane/index.tsx b/superset-frontend/src/SqlLab/components/SouthPane/index.tsx
index 0bbce99b1c..941f0f7523 100644
--- a/superset-frontend/src/SqlLab/components/SouthPane/index.tsx
+++ b/superset-frontend/src/SqlLab/components/SouthPane/index.tsx
@@ -144,14 +144,12 @@ const SouthPane = ({
animated={false}
>
<Tabs.TabPane tab={t('Results')} key="Results">
- {latestQueryId && (
- <Results
- height={innerTabContentHeight}
- latestQueryId={latestQueryId}
- displayLimit={displayLimit}
- defaultQueryLimit={defaultQueryLimit}
- />
- )}
+ <Results
+ height={innerTabContentHeight}
+ latestQueryId={latestQueryId}
+ displayLimit={displayLimit}
+ defaultQueryLimit={defaultQueryLimit}
+ />
</Tabs.TabPane>
<Tabs.TabPane tab={t('Query history')} key="History">
<QueryHistory