You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "koushiro (via GitHub)" <gi...@apache.org> on 2024/10/31 11:53:02 UTC
[PR] chore(core/raw): align info method of `kv::Adapter` and `typed_kv::Adapter` [opendal]
koushiro opened a new pull request, #5259:
URL: https://github.com/apache/opendal/pull/5259
# Which issue does this PR close?
No
# Rationale for this change
The `metadata` method of `kv::Adapter` and `info` method of `typed_kv::Adapter` is misaligned.
# What changes are included in this PR?
- rename `metadata` method of `kv::Adapter`: `fn metadata(&self) -> Metadata;` => `fn info(&self) -> Info;`
- rename `Metadata` type of `kv` module: `pub struct Metadata {...}` => `pub struct Info {...}`
- remove `impl From<kv::Metadata> for AccessorInfo { ... }`
# Are there any user-facing changes?
- rename `kv::Adapter::metadata()` => `kv::Adapter::info()`
- rename `kv::Metadata` => `kv::Info`
- remove `impl From<kv::Metadata> for AccessorInfo { ... }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(core/raw): align `info` method of `kv::Adapter` and `typed_kv::Adapter` [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #5259:
URL: https://github.com/apache/opendal/pull/5259#issuecomment-2456065307
Hi, @koushiro, there are some conflicts preventing us from merging this PR. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(core/raw): align `info` method of `kv::Adapter` and `typed_kv::Adapter` [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5259:
URL: https://github.com/apache/opendal/pull/5259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org