You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/03 16:18:00 UTC
[GitHub] [airflow] maciekgawron opened a new pull request #9122: Fix extracting job_id for gcp dataflow provider.
maciekgawron opened a new pull request #9122:
URL: https://github.com/apache/airflow/pull/9122
In the new version of apache-beam the link from which the airflow is extracting the job id has changed. This commit is fixing the regex for extracting the job_id.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed pull request #9122: Fix extracting job_id for gcp dataflow provider
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #9122:
URL: https://github.com/apache/airflow/pull/9122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9122: Fix extracting job_id for gcp dataflow provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9122:
URL: https://github.com/apache/airflow/pull/9122#issuecomment-644690288
Hey. I made a fix for this problem because many users have reported this problem. My change is already merged.
https://github.com/apache/airflow/pull/9323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9122: Fix extracting job_id for gcp dataflow provider.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9122:
URL: https://github.com/apache/airflow/pull/9122#issuecomment-638302923
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9122: Fix extracting job_id for gcp dataflow provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9122:
URL: https://github.com/apache/airflow/pull/9122#issuecomment-638321505
I contacted the Cloud Dataflow product team. We should use the following regular expressions.
> for java and go: Submitted job: (.*)
> for python: Created job with id: \[(.*)\]
Searching for Job ID by URL is not a good idea. Can you check my proposition?
Moreover, we should prepare system tests that will check if these two versions are still working properly. For Python, this means adding a new task in the sample DAG with a different version.
https://github.com/apache/airflow/blob/1c9374d2573483dd66f5c35032e24140864e72c0/airflow/providers/google/cloud/example_dags/example_dataflow.py#L120
For Java, we need to prepare two JAR files. We can do it with Cloud Build so that everyone can easily access it. Here is example: https://github.com/apache/airflow/blob/aa29389cac91f29f5f37b268fa61c0a3eaabd663/tests/providers/google/cloud/operators/test_dataflow_system.py
If you don't have time, then you don't have to do system tests for Java, but I would be very happy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org