You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "helenosheaa (via GitHub)" <gi...@apache.org> on 2023/06/27 16:25:57 UTC
[GitHub] [superset] helenosheaa opened a new pull request, #24531: docs(databases): add influxdb to database drivers list
helenosheaa opened a new pull request, #24531:
URL: https://github.com/apache/superset/pull/24531
### SUMMARY
Since the [development](https://github.com/influxdata/flightsql-dbapi) of the [flightsql-dbapi](https://pypi.org/project/flightsql-dbapi/) pypi package, users can now use this to connect InfluxDB 3.0 to superset. We'd like to advertise this on your database driver page.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER:
<img width="1468" alt="Screen Shot 2023-06-27 at 12 21 41 PM" src="https://github.com/apache/superset/assets/38860767/08a7c71c-860b-4789-9441-d9da1a10ceb2">
<img width="1411" alt="Screen Shot 2023-06-27 at 12 21 56 PM" src="https://github.com/apache/superset/assets/38860767/b7a2cb5e-2234-4d49-b61c-38f49c8d3d34">
### TESTING INSTRUCTIONS
run the docs locally to confirm no breaking changes
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] helenosheaa commented on pull request #24531: docs(databases): add influxdb to database drivers list
Posted by "helenosheaa (via GitHub)" <gi...@apache.org>.
helenosheaa commented on PR #24531:
URL: https://github.com/apache/superset/pull/24531#issuecomment-1625526739
@villebro i'm not sure if this engine spec is needed/correct if you can take a look
our engine/dialect definition is defined [here](https://github.com/influxdata/flightsql-dbapi/wiki/InfluxDB-IOx#sqlalchemy-with-the-datafusion-dialect)
but i wasn't sure if it should just be referring to it as influxdb3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(databases): add influxdb to database drivers list [superset]
Posted by "zoesteinkamp (via GitHub)" <gi...@apache.org>.
zoesteinkamp commented on PR #24531:
URL: https://github.com/apache/superset/pull/24531#issuecomment-1949192050
I think this is good to be approved correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24531: docs(databases): add influxdb to database drivers list
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24531:
URL: https://github.com/apache/superset/pull/24531#issuecomment-1609881831
This is great to hear @helenosheaa ! One question, does this dialect support any kind of time grain functionality (typically `DATE_TRUNC` or similar)? I would assume this is a fairly important feature when doing analytics on a timeseries database. If so, we would need to add a db engine spec to support it. Let me know if you need help with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] helenosheaa commented on pull request #24531: docs(databases): add influxdb to database drivers list
Posted by "helenosheaa (via GitHub)" <gi...@apache.org>.
helenosheaa commented on PR #24531:
URL: https://github.com/apache/superset/pull/24531#issuecomment-1609946841
@villebro thanks for the quick feedback so SQL Alchemy which is the dialect does support date_trunc, however i don't know if the pypi package has been setup to translate that to time grains.. or is that what the db engine spec does? screenshot of me running it against docker without any time grains:
<img width="1527" alt="Screen Shot 2023-06-27 at 1 30 59 PM" src="https://github.com/apache/superset/assets/38860767/4cd8ebdd-ce19-4520-b250-4d2d78faa057">
If so I can have a go at creating one, I see the other examples look straightforward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org