Re: [PR] feat(c/include/arrow-adbc): Add AdbcStatementRequestSchema [arrow-adbc]

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #3623:
URL: https://github.com/apache/arrow-adbc/pull/3623#discussion_r3612546953


##########
c/include/arrow-adbc/adbc.h:
##########
@@ -2293,6 +2296,36 @@ AdbcStatusCode AdbcStatementExecuteSchema(struct AdbcStatement* statement,
                                           struct ArrowSchema* schema,
                                           struct AdbcError* error);
 
+/// \brief Request the schema of the next statement execution
+///
+/// Allows the caller to request a specific schema based on prior

Review Comment:
   What's the status here?
   
   Personally I'm fine saying that you have to match (at least to start), though allowing widened nullability seems fine, and if there's a use case we can define the rest. Reordering columns and such to me starts to feel like #13 a bit. If only everyone supported Substrait, things would be easy :P



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org