You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "Mamta A. Satoor (JIRA)" <ji...@apache.org> on 2007/04/22 05:43:15 UTC

[jira] Updated: (DERBY-2578) Change CurrentDatetimeOperatorNode to use ExpressionClassBuilder to generate code for DVD rather than going directly though TypeCompiler

     [ https://issues.apache.org/jira/browse/DERBY-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mamta A. Satoor updated DERBY-2578:
-----------------------------------

    Attachment: DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_stat.txt
                DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_diff.txt

Attaching patch to address this Jira entry. Will commit in next few minutes. No new failures caused by the patch.

> Change CurrentDatetimeOperatorNode to use ExpressionClassBuilder to generate code for DVD rather than going directly though TypeCompiler
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2578
>                 URL: https://issues.apache.org/jira/browse/DERBY-2578
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_diff.txt, DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_stat.txt
>
>
> I am starting to think about the code generation for DERBY-1478 language based ordering. Depending on the collation type of the DTD, we might want to generate CollatorSQLChar rather than SQLChar for instance. In order to centralize this code, I am changing CurrentDatetimeOperatorNode's generateExpression so that it goes through ExpressionClassBuilder.generateDataValue rather than doing TypeCompiler.generateDataValue. This way, hopefully, I will only have to change  ExpressionClassBuilder.generateDataValue to take care of the collation dependency of DVD generation. All the other classes which need to generate a DVD already go through ExpressionClassBuilder.generateDataValue. Will commit the patch for this soon. The tests have passed with no new failures.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.