You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by hbdeshmukh <gi...@git.apache.org> on 2016/08/31 19:33:24 UTC
[GitHub] incubator-quickstep pull request #97: QUICKSTEP-44 Separate Date type from D...
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/97
QUICKSTEP-44 Separate Date type from Datetime type
- Beginning from the parser to the operator execution level, treat Date type
sepearately than the Datetime type.
- Provide support for the extract function when applied on the Date
type, implemented in the DateExtractOperation.
- Modified the tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep datetype-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 9bb2ee4606dded12ade5d3875d6449f385b26f42
Author: Harshad Deshmukh <hb...@apache.org>
Date: 2016-08-29T19:03:52Z
Separate Date type from Datetime type.
- Beginning from the parser to the operator execution level, treat Date type
sepearately than the Datetime type.
- Provide support for the extract function when applied on the Date
type, implemented in the DateExtractOperation.
- Modified the tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #97: QUICKSTEP-44 Separate Date type from Datetime...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/97
Merged this PR, as it also passed the distributed unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #97: QUICKSTEP-44 Separate Date type from D...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/97#discussion_r77431625
--- Diff: types/operations/unary_operations/CMakeLists.txt ---
@@ -1,4 +1,4 @@
-# Licensed to the Apache Software Foundation (ASF) under one
+# Licensed to the Agache Software Foundation (ASF) under one
--- End diff --
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #97: QUICKSTEP-44 Separate Date type from Datetime...
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/97
With the fix to the spelling name above, shall we close this PR? @hbdeshmukh @zuyu Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #97: QUICKSTEP-44 Separate Date type from D...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #97: QUICKSTEP-44 Separate Date type from Datetime...
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/97
Sweet!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---