You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (Commented) (JIRA)" <ji...@apache.org> on 2011/12/12 20:53:32 UTC
[jira] [Commented] (THRIFT-1461) Recent TNonblockingServer changes
broke --enable-boostthreads=yes, Windows
[ https://issues.apache.org/jira/browse/THRIFT-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167722#comment-13167722 ]
Roger Meier commented on THRIFT-1461:
-------------------------------------
patch looks good, but I have an issue with the libevent version... Debian Squeeze still uses 1.4.13
It seems that evutil_make_socket_closeonexec is not available. Do you have an alternative?
{noformat}
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -std=c++0x -MT libthriftnb_la-TNonblockingServer.lo -MD -MP -MF .deps/libthriftnb_la-TNonblockingServer.Tpo -c src/server/TNonblockingServer.cpp -fPIC -DPIC -o .libs/libthriftnb_la-TNonblockingServer.o
src/server/TNonblockingServer.cpp: In member function 'void apache::thrift::server::TNonblockingIOThread::createNotificationPipe()':
src/server/TNonblockingServer.cpp:1300: error: 'evutil_make_socket_closeonexec' was not declared in this scope
{noformat}
> Recent TNonblockingServer changes broke --enable-boostthreads=yes, Windows
> --------------------------------------------------------------------------
>
> Key: THRIFT-1461
> URL: https://issues.apache.org/jira/browse/THRIFT-1461
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Linux, Windows
> Reporter: alexandre parenteau
> Labels: patch
> Fix For: 0.9
>
> Attachments: THRIFT_1461.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Following the (nice) improvements for TNonblockingServer in THRIFT-1442, this patch restores both --enable-boostthreads=yes, and the Windows build.
> Included in this patch:
> - Add more HAVE_CONFIG_H includes
> - Replace PosixThreadFactory by PlatformThreadFactory where appropriate
> - Abstract away pthread vs boost::thread inside Thread.h, adding new methods is_current/get_current
> - Renamed INVALID_SOCKET, caused compilation problems on Windows (already defined in WinSock2.h)
> - Restore back more portable evutil_socketpair (in place of pipe, for Windows)
> - Add evutil_make_socket_nonblocking (as of THRIFT-1442)
> Also included (minor):
> - Add x64 target to VisualC++ compiler
> - Fix minor glitch in bison/compiler for VisualC++
> - Remove more VisualC++ warnings
> This was tested on Ubuntu 10.10, Boost 1.44, Libevent 2.0.16, Visual C++ 10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira