[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #11403: refactor the hikariCP metrics and remove dependency on prometheus from proxy

[GitBox <gi...@apache.org>]

TeslaCN commented on a change in pull request #11403:
URL: https://github.com/apache/shardingsphere/pull/11403#discussion_r672788021



##########
File path: shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/register/PrometheusMetricsRegister.java
##########
@@ -128,6 +131,14 @@ public void recordTime(final String name, final String[] labelValues, final long
         }
     }
     
+    @Override
+    public void addMetricsFactory(final Object obj) {
+        if (null != obj && obj instanceof HikariDataSource) {

Review comment:
       Is `null != obj` unnecessary?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org