You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/11 10:59:00 UTC
[jira] [Work logged] (KNOX-2099) knoxshell buildTrustStore doesn't
work on a url without a port
[ https://issues.apache.org/jira/browse/KNOX-2099?focusedWorklogId=341235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341235 ]
ASF GitHub Bot logged work on KNOX-2099:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 10:58
Start Date: 11/Nov/19 10:58
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #188: KNOX-2099 - Checking if provided gateway URL has 'host' and 'port' parts before trying to open a connection when building truststore
URL: https://github.com/apache/knox/pull/188
## What changes were proposed in this pull request?
Doing some basic validation before opening a connection to the provided gateway URL.
## How was this patch tested?
Added new unit test and ran the tool locally:
```
$ bin/knoxshell.sh buildTrustStore https://localhost
Invalid 'knox-gateway-url' provided!
Finished work without building truststore
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 341235)
Remaining Estimate: 0h
Time Spent: 10m
> knoxshell buildTrustStore doesn't work on a url without a port
> --------------------------------------------------------------
>
> Key: KNOX-2099
> URL: https://issues.apache.org/jira/browse/KNOX-2099
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxShell
> Affects Versions: 1.3.0
> Reporter: Kevin Risden
> Assignee: Sandor Molnar
> Priority: Major
> Labels: beginner
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> knoxshell buildTrustStore doesn't work on a url without a port
> {code:java}
> ./bin/knoxshell.sh buildTrustStore https://knox_host
> Opening connection to knoxhost:-1...
> org.apache.knox.gateway.shell.KnoxShellException: Error while building trust store
> at org.apache.knox.gateway.shell.KnoxSh$KnoxBuildTrustStore.execute(KnoxSh.java:194)
> at org.apache.knox.gateway.shell.KnoxSh.run(KnoxSh.java:85)
> at org.apache.knox.gateway.shell.KnoxSh.main(KnoxSh.java:392)
> Caused by: java.lang.IllegalArgumentException: port out of range:-1
> at java.net.InetSocketAddress.checkPort(InetSocketAddress.java:143)
> at java.net.InetSocketAddress.<init>(InetSocketAddress.java:224)
> at sun.security.ssl.SSLSocketImpl.<init>(SSLSocketImpl.java:423)
> at sun.security.ssl.SSLSocketFactoryImpl.createSocket(SSLSocketFactoryImpl.java:88)
> at org.apache.knox.gateway.shell.KnoxSh$KnoxBuildTrustStore.fetchPublicCertsFromGatewayServer(KnoxSh.java:209)
> at org.apache.knox.gateway.shell.KnoxSh$KnoxBuildTrustStore.execute(KnoxSh.java:186)
> ... 2 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)