You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/28 06:57:56 UTC

[GitHub] [arrow-datafusion] AssHero opened a new pull request, #2634: if none columns in window expr are needed, remove the window exprs

AssHero opened a new pull request, #2634:
URL: https://github.com/apache/arrow-datafusion/pull/2634

   # Which issue does this PR close?
   
   Closes #2542 
   
    # Rationale for this change
   if the columns in window exprs are not referenced by operator, we can remove the window exprs.
   
   # What changes are included in this PR?
   remove the window exprs in projection_push_down.rs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] AssHero commented on pull request #2634: if none columns in window expr are needed, remove the window exprs

Posted by GitBox <gi...@apache.org>.
AssHero commented on PR #2634:
URL: https://github.com/apache/arrow-datafusion/pull/2634#issuecomment-1140358033

   > Thank you @AssHero -- can you please add a test case to this PR showing that it fixes the issue reported on #2542?
   > 
   > Perhaps you can add the reproducer from @mateuszkj to https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sql/window.rs?
   
   yes, i can add a test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #2634: if none columns in window expr are needed, remove the window exprs

Posted by GitBox <gi...@apache.org>.
alamb merged PR #2634:
URL: https://github.com/apache/arrow-datafusion/pull/2634


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] AssHero commented on pull request #2634: if none columns in window expr are needed, remove the window exprs

Posted by GitBox <gi...@apache.org>.
AssHero commented on PR #2634:
URL: https://github.com/apache/arrow-datafusion/pull/2634#issuecomment-1140575078

   > Looks good to me -- thank you @AssHero
   
   My pleasure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org