You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "panzhi33 (via GitHub)" <gi...@apache.org> on 2026/03/12 11:59:47 UTC

[PR] support simple consumer supports subscribing to multiple topics [rocketmq-spring]

panzhi33 opened a new pull request, #772:
URL: https://github.com/apache/rocketmq-spring/pull/772

   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. 
   - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] support simple consumer supports subscribing to multiple topics [rocketmq-spring]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on code in PR #772:
URL: https://github.com/apache/rocketmq-spring/pull/772#discussion_r3844011915


##########
rocketmq-v5-client-spring-boot-samples/pom.xml:
##########
@@ -35,7 +35,9 @@
         <module>rocketmq-v5-client-producer-simple-demo</module>
         <module>rocketmq-v5-client-consumer-simple-demo</module>
         <module>rocketmq-v5-client-consumer-push-simple-demo</module>
-    </modules>
+		<module>rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo</module>

Review Comment:
   This module is listed twice — `rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo` appears on both line 38 and 39. This will cause a Maven build error (`Malformed POM`). Please remove the duplicate entry.



##########
rocketmq-v5-client-spring-boot-samples/pom.xml:
##########
@@ -35,7 +35,9 @@
         <module>rocketmq-v5-client-producer-simple-demo</module>
         <module>rocketmq-v5-client-consumer-simple-demo</module>
         <module>rocketmq-v5-client-consumer-push-simple-demo</module>
-    </modules>
+		<module>rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo</module>

Review Comment:
   Typo in module name: `muliti` should be `multi`. Consider renaming the directory and module to `rocketmq-v5-client-consume-simple-subscribe-multi-topic-demo`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] support simple consumer supports subscribing to multiple topics [rocketmq-spring]

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #772:
URL: https://github.com/apache/rocketmq-spring/pull/772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] support simple consumer supports subscribing to multiple topics [rocketmq-spring]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #772:
URL: https://github.com/apache/rocketmq-spring/pull/772#issuecomment-5227923231

   **Issue Evaluation**
   
   Category: `enhancement` | Status: **Evaluated**
   
   This is a feature request to support SimpleConsumer subscribing to multiple topics simultaneously. Currently, SimpleConsumer in rocketmq-spring is limited to single-topic subscription.
   
   **Feasibility:** feasible
   **Scope:** `rocketmq-spring-boot-starter`, SimpleConsumer configuration and listener registration
   **Compatibility:** additive change, no breaking changes expected
   
   This aligns with the v5 client SDK SimpleConsumer design which already supports multi-topic consumption. The spring starter should expose this capability through configuration.
   
   ---
   *Automated evaluation by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] support simple consumer supports subscribing to multiple topics [rocketmq-spring]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #772:
URL: https://github.com/apache/rocketmq-spring/pull/772#issuecomment-5328332483

   Hi @panzhi33, thanks for this contribution adding multi-topic subscription support for the simple consumer.
   
   A few things need attention before this can be reviewed:
   
   1. **PR description is incomplete** — The template placeholders (`XXXXX`) haven't been filled in. Please update the description with:
      - What the change does and why
      - How to verify the change
      - Any relevant issue references
   
   2. **This PR is 5 months old** — Could you confirm this is still actively being worked on? If the feature is no longer needed, please close the PR.
   
   3. **Typo in module name** — The sample module is named `rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo` (note: `muliti` should be `multi`).
   
   Please update the PR description and we can proceed with a proper review.
   
   ---
   *Automated notification by github-manager-bot*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org