You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2008/02/28 11:50:03 UTC

[Bug 44504] New: [patch] Improvements to FormulaParser - operators, precedence, error literals, etc

https://issues.apache.org/bugzilla/show_bug.cgi?id=44504

           Summary: [patch] Improvements to FormulaParser - operators,
                    precedence, error literals, etc
           Product: POI
           Version: 3.0-dev
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HSSF
        AssignedTo: dev@poi.apache.org
        ReportedBy: josh@gildedtree.com


There's some big changes here.  It's best to first look at all of the added
test cases in TestFormulaParser to get an overview of the work.  (The new tests
can be merged in first, to observe POI's current behaviour with

Added support for parsing of '%' in formulas.
Fixed operator precedence (and confirmed associativity):
        (), %, ^, * /, + -, &, = <> > >= < <= 
Simplified missing arg parse logic and confirmed with test
Added support for error literals (like #REF!) in formulas.
Fixed parsing of string literals
Simplified logic of rendering IF() and external functions

Started support for evaluation of external functions.

Made FormulaParser detect when the input string has not been consumed.  Removed
all occurrences appending a semicolon to the formula before parsing (that code
made no difference before).

Performed major refactorings inside FormulaParser to fix all of this.
Added class FormulaParser.FormulaParseException to help distinguish specific
parsing errors from internal POI errors.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 44504] [patch] Improvements to FormulaParser - operators, precedence, error literals, etc

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44504





--- Comment #2 from Josh Micich <jo...@gildedtree.com>  2008-02-28 02:52:31 ---
Created an attachment (id=21599)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21599)
tar bzip of 3 added files


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 44504] [patch] Improvements to FormulaParser - operators, precedence, error literals, etc

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44504





--- Comment #1 from Josh Micich <jo...@gildedtree.com>  2008-02-28 02:51:41 ---
Created an attachment (id=21598)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21598)
svn diff of 10 changed files


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

DO NOT REPLY [Bug 44504] [patch] Improvements to FormulaParser - operators, precedence, error literals, etc

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44504


Nick Burch <ni...@torchbox.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Nick Burch <ni...@torchbox.com>  2008-03-04 08:49:07 ---
Applied to svn trunk, thanks


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org