You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2010/05/27 11:55:40 UTC
[jira] Created: (JCR-2643) Avoid item state reads during
Session.logout()
Avoid item state reads during Session.logout()
----------------------------------------------
Key: JCR-2643
URL: https://issues.apache.org/jira/browse/JCR-2643
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-core
Reporter: Marcel Reutegger
Priority: Minor
This is a follow up issue for JCR-2231. There's a second CachingHierarchyManager attached to the LocalItemStateManager, which it unregistered too late and causes reads on the SharedItemStateManager on Session logout. The hierarchy manager should be unregistered as listener before the state manager is disposed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-2643) Avoid item state reads during
Session.logout()
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger resolved JCR-2643.
-----------------------------------
Fix Version/s: 2.2.0
Resolution: Fixed
Applied jackrabbit-core patch in revision: 949724
> Avoid item state reads during Session.logout()
> ----------------------------------------------
>
> Key: JCR-2643
> URL: https://issues.apache.org/jira/browse/JCR-2643
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Marcel Reutegger
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: JCR-2643.patch, jcr-benchmark.patch
>
>
> This is a follow up issue for JCR-2231. There's a second CachingHierarchyManager attached to the LocalItemStateManager, which it unregistered too late and causes reads on the SharedItemStateManager on Session logout. The hierarchy manager should be unregistered as listener before the state manager is disposed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2643) Avoid item state reads during
Session.logout()
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873631#action_12873631 ]
Marcel Reutegger commented on JCR-2643:
---------------------------------------
Added test to jcr-benchmark suite in revision: 949722
> Avoid item state reads during Session.logout()
> ----------------------------------------------
>
> Key: JCR-2643
> URL: https://issues.apache.org/jira/browse/JCR-2643
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-2643.patch, jcr-benchmark.patch
>
>
> This is a follow up issue for JCR-2231. There's a second CachingHierarchyManager attached to the LocalItemStateManager, which it unregistered too late and causes reads on the SharedItemStateManager on Session logout. The hierarchy manager should be unregistered as listener before the state manager is disposed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-2643) Avoid item state reads during
Session.logout()
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated JCR-2643:
----------------------------------
Attachment: jcr-benchmark.patch
JCR-2643.patch
Patches add test to jcr-benchmark suite and unregister the hierarchy manager before item state manager dispose, which was
actually called twice. First in SessionItemStateManager.dispose() and then in WorkspaceImpl.dispose() again.
> Avoid item state reads during Session.logout()
> ----------------------------------------------
>
> Key: JCR-2643
> URL: https://issues.apache.org/jira/browse/JCR-2643
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-2643.patch, jcr-benchmark.patch
>
>
> This is a follow up issue for JCR-2231. There's a second CachingHierarchyManager attached to the LocalItemStateManager, which it unregistered too late and causes reads on the SharedItemStateManager on Session logout. The hierarchy manager should be unregistered as listener before the state manager is disposed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2643) Avoid item state reads during
Session.logout()
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872169#action_12872169 ]
Marcel Reutegger commented on JCR-2643:
---------------------------------------
jcr-benchmark results
current:
Test case Mean Sdev Min Max Count
----------------------------------------------------------------------------
1000 x login() 82 115 47 1105 405
1000 x login().logout() 87 84 53 406 575
1000 x logout() after reads 128 94 100 1027 105
patched:
Test case Mean Sdev Min Max Count
----------------------------------------------------------------------------
1000 x login() 80 114 46 1106 472
1000 x login().logout() 87 84 52 353 581
1000 x logout() after reads 34 96 15 1102 142
> Avoid item state reads during Session.logout()
> ----------------------------------------------
>
> Key: JCR-2643
> URL: https://issues.apache.org/jira/browse/JCR-2643
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-2643.patch, jcr-benchmark.patch
>
>
> This is a follow up issue for JCR-2231. There's a second CachingHierarchyManager attached to the LocalItemStateManager, which it unregistered too late and causes reads on the SharedItemStateManager on Session logout. The hierarchy manager should be unregistered as listener before the state manager is disposed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.