You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by ka...@apache.org on 2019/12/02 03:23:51 UTC
[phoenix] branch 4.14-HBase-1.3 updated: PHOENIX-5596: Add metric
for every index row inspected for verification status
This is an automated email from the ASF dual-hosted git repository.
kadir pushed a commit to branch 4.14-HBase-1.3
in repository https://gitbox.apache.org/repos/asf/phoenix.git
The following commit(s) were added to refs/heads/4.14-HBase-1.3 by this push:
new 48eb9ca PHOENIX-5596: Add metric for every index row inspected for verification status
48eb9ca is described below
commit 48eb9ca6cad06b0be62f3888eb8805a537953388
Author: Priyank <pp...@salesforce.com>
AuthorDate: Wed Nov 27 14:08:09 2019 -0800
PHOENIX-5596: Add metric for every index row inspected for verification status
Signed-off-by: Kadir <ko...@salesforce.com>
---
.../phoenix/hbase/index/metrics/GlobalIndexCheckerSource.java | 8 ++++++++
.../hbase/index/metrics/GlobalIndexCheckerSourceImpl.java | 9 +++++++++
.../main/java/org/apache/phoenix/index/GlobalIndexChecker.java | 2 ++
3 files changed, 19 insertions(+)
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSource.java b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSource.java
index 84b03d1..837b137 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSource.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSource.java
@@ -29,6 +29,9 @@ public interface GlobalIndexCheckerSource extends BaseSource {
String METRICS_DESCRIPTION = "Metrics about the Phoenix Global Index Checker";
String METRICS_JMX_CONTEXT = "RegionServer,sub=" + METRICS_NAME;
+ String INDEX_INSPECTION = "indexInspections";
+ String INDEX_INSPECTION_DESC = "The number of index rows inspected for verified status";
+
String INDEX_REPAIR = "indexRepairs";
String INDEX_REPAIR_DESC = "The number of index row repairs";
@@ -42,6 +45,11 @@ public interface GlobalIndexCheckerSource extends BaseSource {
String INDEX_REPAIR_FAILURE_TIME_DESC = "Histogram for the time in milliseconds for index row repair failures";
/**
+ * Increments the number of index rows inspected for verified status
+ */
+ public void incrementIndexInspections();
+
+ /**
* Increments the number of index repairs
*/
void incrementIndexRepairs();
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSourceImpl.java b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSourceImpl.java
index f59851a..b8571de 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSourceImpl.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSourceImpl.java
@@ -25,6 +25,7 @@ import org.apache.hadoop.metrics2.lib.MutableFastCounter;
*/
public class GlobalIndexCheckerSourceImpl extends BaseSourceImpl implements GlobalIndexCheckerSource {
+ private final MutableFastCounter indexInspections;
private final MutableFastCounter indexRepairs;
private final MutableFastCounter indexRepairFailures;
@@ -41,6 +42,7 @@ public class GlobalIndexCheckerSourceImpl extends BaseSourceImpl implements Glob
String metricsJmxContext) {
super(metricsName, metricsDescription, metricsContext, metricsJmxContext);
+ indexInspections = getMetricsRegistry().newCounter(INDEX_INSPECTION, INDEX_INSPECTION_DESC, 0L);
indexRepairs = getMetricsRegistry().newCounter(INDEX_REPAIR, INDEX_REPAIR_DESC, 0L);
indexRepairFailures = getMetricsRegistry().newCounter(INDEX_REPAIR_FAILURE, INDEX_REPAIR_FAILURE_DESC, 0L);
@@ -49,6 +51,13 @@ public class GlobalIndexCheckerSourceImpl extends BaseSourceImpl implements Glob
}
/**
+ * Increments the number of index rows inspected for verified status
+ */
+ public void incrementIndexInspections() {
+ indexInspections.incr();
+ }
+
+ /**
* Increments the number of index repairs
*/
public void incrementIndexRepairs() {
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java b/phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
index 6acdfbc..170da53 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
@@ -476,6 +476,8 @@ public class GlobalIndexChecker extends BaseRegionObserver {
* @throws IOException
*/
private boolean verifyRowAndRepairIfNecessary(List<Cell> cellList) throws IOException {
+ metricsSource.incrementIndexInspections();
+
Cell cell = cellList.get(0);
if (verifyRowAndRemoveEmptyColumn(cellList)) {
return true;