[jira] [Commented] (FLINK-3277) Use Value types in Gelly API

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262378#comment-15262378 ] 

ASF GitHub Bot commented on FLINK-3277:
---------------------------------------

Github user greghogan commented on the pull request:

    https://github.com/apache/flink/pull/1671#issuecomment-215474401
  
    @StephanEwen in [FLINK-3768](https://github.com/apache/flink/pull/1896) I compared an optimal algorithm to the current implementation in Gelly and the optimal algorithm was 53% faster. There is some additional complexity in the optimal algorithm that I have since removed so I'd expect it to be about 60% faster.


> Use Value types in Gelly API
> ----------------------------
>
>                 Key: FLINK-3277
>                 URL: https://issues.apache.org/jira/browse/FLINK-3277
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 1.0.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> This would be a breaking change so the discussion needs to happen before the 1.0.0 release.
> I think it would benefit Flink to use {{Value}} types wherever possible. The {{Graph}} functions {{inDegrees}}, {{outDegrees}}, and {{getDegrees}} each return {{DataSet<Tuple2<K, Long>>}}. Using {{Long}} creates a new heap object for every serialization and deserialization. The mutable {{Value}} types do not suffer from this issue when object reuse is enabled.
> I lean towards a preference for conciseness in documentation and performance in examples and APIs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)