[jira] [Commented] (CALCITE-4992) RestClient resource leak in ElasticSearch adapter

["ZheHu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480122#comment-17480122 ] 

ZheHu commented on CALCITE-4992:
--------------------------------

Hi, [~dzamo] . Thanks for reporting this. I've left some minor comments on Github. 
By the way, it'll be very helpful if you simply show us how Drill's ES plugin make use of ES Adapter in Calcite.
 

> RestClient resource leak in ElasticSearch adapter
> -------------------------------------------------
>
>                 Key: CALCITE-4992
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4992
>             Project: Calcite
>          Issue Type: Bug
>          Components: elasticsearch-adapter
>    Affects Versions: 1.29.0
>            Reporter: James Turton
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.30.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> RestClient instances should receive a `close()`call at the end of their lifecyle, as documented here.
> [https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-low-usage-initialization.html]
> We have monitored file descriptor leaks on systems running Apache Drill and found that they are associated with Drill's ElasticSearch plugin, and that in turn makes use of Calcite's ElasticSearch adapter.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)