[GitHub] [inlong] healchow commented on a diff in pull request #7621: [INLONG-7619][Manager] Support retry mysqlSources after updating MysqlDataNode

["healchow (via GitHub)" <gi...@apache.org>]

healchow commented on code in PR #7621:
URL: https://github.com/apache/inlong/pull/7621#discussion_r1138235812


##########
inlong-manager/manager-dao/src/main/resources/mappers/StreamSourceEntityMapper.xml:
##########
@@ -319,7 +319,24 @@
             for update
         </where>
     </select>
-
+    <select id="selectByClusterAndDataNode" resultType="org.apache.inlong.manager.dao.entity.StreamSourceEntity">
+        select
+        <include refid="Base_Column_List"/>
+        from stream_source
+        <where>
+            is_deleted = 0
+            and status not in (99, 110)

Review Comment:
   Why filter those status?
   Can we description it on the method name, such as `selectNormalXxx` or `selectUnDeletedXxx`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org