You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/12/31 07:46:44 UTC
[jira] Created: (HADOOP-4965) DFSClient should log instead of
printing into std err.
DFSClient should log instead of printing into std err.
------------------------------------------------------
Key: HADOOP-4965
URL: https://issues.apache.org/jira/browse/HADOOP-4965
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Affects Versions: 0.17.0
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 0.20.0
{{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660072#action_12660072 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4965:
------------------------------------------------
This patch may change the shell commands output.
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4965:
----------------------------------------
Attachment: DFSClientLogging.patch
This patch
- prints the file name;
- stringifyException
- also closes FileSystem in TestFileAppend3
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4965:
----------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.20.0)
0.19.1
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.1
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch, DFSClientLogging.patch, TestFileAppend3.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4965:
----------------------------------------
Component/s: (was: dfs)
test
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch, DFSClientLogging.patch, TestFileAppend3.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4965:
----------------------------------------
Status: Patch Available (was: Open)
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4965:
----------------------------------------
Attachment: DFSClientLogging.patch
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663334#action_12663334 ]
Steve Loughran commented on HADOOP-4965:
----------------------------------------
You shouldn't need to call {{StringUtils.stringifyException()}}, because passing it down to the log tools as is lets your logging tool handle the chained strack trace themselves -which can include a more structured output than the {{stringifyException()}} call. I'd prefer something like:
{{LOG.error("Exception closing file " + src + ": " +ie,ie);}}
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4965:
----------------------------------------
Attachment: DFSClientLogging.patch
Incorporated Suresh's comment.
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch, DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663972#action_12663972 ]
Konstantin Shvachko commented on HADOOP-4965:
---------------------------------------------
Only one unit test failure with this patch. TestMapReduceLocal fails as in HADOOP-4907.
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch, DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663975#action_12663975 ]
Suresh Srinivas commented on HADOOP-4965:
-----------------------------------------
+1 for the patch
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch, DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4965:
----------------------------------------
Attachment: TestFileAppend3.patch
I am removing the DFSClient related code from the patch because it has been resolved by HADOOP-3894. Leaving only the TestFileAppend3 improvement.
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch, DFSClientLogging.patch, TestFileAppend3.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4965) DFSClient should log instead of
printing into std err.
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660043#action_12660043 ]
Suresh Srinivas commented on HADOOP-4965:
-----------------------------------------
Previously the file name was printed. Should the file name be printed in the log? Otherwise +1 for the patch.
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}} should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.