You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/03/28 10:53:33 UTC
Review Request 57871: Referenced Kerberos identity definitions should
be
created and distributed only if the referenced service or component is
installed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57871/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Bugs: AMBARI-20540
https://issues.apache.org/jira/browse/AMBARI-20540
Repository: ambari
Description
-------
Referenced Kerberos identity definitions should be created and distributed only if the referenced service is installed.
For example, if a service or component declares a referenced Kerberos identity definition like
{
"name": "/HDFS/NAMENODE/hdfs"
},
The referenced identity, "/HDFS/NAMENODE/hdfs", should only be included related to principal and keytab file creation if the HDFS service is installed in the cluster.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java 53c69f1
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java ae78de6
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java 0031be7
ambari-server/src/test/resources/kerberos/test_filtering_identity_descriptor.json PRE-CREATION
Diff: https://reviews.apache.org/r/57871/diff/1/
Testing
-------
added new unittest, tested kerberization manually
existing unittests executed successfully
Thanks,
Attila Magyar
Re: Review Request 57871: Referenced Kerberos identity definitions
should be
created and distributed only if the referenced service or component is
installed
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57871/#review170316
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On March 28, 2017, 6:53 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57871/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 6:53 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20540
> https://issues.apache.org/jira/browse/AMBARI-20540
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Referenced Kerberos identity definitions should be created and distributed only if the referenced service is installed.
> For example, if a service or component declares a referenced Kerberos identity definition like
> {
> "name": "/HDFS/NAMENODE/hdfs"
> },
> The referenced identity, "/HDFS/NAMENODE/hdfs", should only be included related to principal and keytab file creation if the HDFS service is installed in the cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java 53c69f1
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java ae78de6
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java 0031be7
> ambari-server/src/test/resources/kerberos/test_filtering_identity_descriptor.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57871/diff/1/
>
>
> Testing
> -------
>
> added new unittest, tested kerberization manually
>
> existing unittests executed successfully
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 57871: Referenced Kerberos identity definitions
should be
created and distributed only if the referenced service or component is
installed
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57871/#review170298
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On March 28, 2017, 12:53 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57871/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 12:53 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20540
> https://issues.apache.org/jira/browse/AMBARI-20540
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Referenced Kerberos identity definitions should be created and distributed only if the referenced service is installed.
> For example, if a service or component declares a referenced Kerberos identity definition like
> {
> "name": "/HDFS/NAMENODE/hdfs"
> },
> The referenced identity, "/HDFS/NAMENODE/hdfs", should only be included related to principal and keytab file creation if the HDFS service is installed in the cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java 53c69f1
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java ae78de6
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java 0031be7
> ambari-server/src/test/resources/kerberos/test_filtering_identity_descriptor.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57871/diff/1/
>
>
> Testing
> -------
>
> added new unittest, tested kerberization manually
>
> existing unittests executed successfully
>
>
> Thanks,
>
> Attila Magyar
>
>