You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/22 11:24:28 UTC
[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on a change in pull request #392: [YUNIKORN-1140] Update e2e tests to work with new REST API changes
craigcondit commented on a change in pull request #392:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/392#discussion_r832060758
##########
File path: test/e2e/framework/helpers/yunikorn/yk_utils.go
##########
@@ -19,34 +19,26 @@
package yunikorn
import (
- "errors"
"fmt"
- "regexp"
"github.com/apache/incubator-yunikorn-k8shim/test/e2e/framework/configmanager"
)
type ResourceUsage struct {
- memory string
- vCPU string
+ memory int64
+ vCPU int64
Review comment:
Yes they really do. Int only allows for 4 GB RAM for example. All resources internally are mow 64-bit quantities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org