You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ilia Shakitko <i....@tech.leaseweb.com> on 2014/08/22 11:36:33 UTC
Review Request 24969: [CLOUDSTACK-7398] SecurityGroupRule tags
cleanup on rule deletion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24969/
-----------------------------------------------------------
Review request for cloudstack, Abhishek Agarwal, Alena Prokharchyk, edison su, Kelven Yang, and Wei Zhou.
Bugs: CLOUDSTACK-7398
https://issues.apache.org/jira/browse/CLOUDSTACK-7398
Repository: cloudstack-git
Description
-------
When deleting a SecurityGroup rule with some tags linked to it, tags are still being exist in DB. And they are linked to a non-existing resource now (since SG rule was deleted)
Diffs
-----
engine/schema/src/com/cloud/network/security/dao/SecurityGroupRuleDaoImpl.java 564ec08
Diff: https://reviews.apache.org/r/24969/diff/
Testing
-------
Tested on master branch (codebase 21st of August).
1) Created a SG rule
2) Created few tags for that rule
3) Deleted that rule and check listTags
4) Tags have also been deleted
Thanks,
Ilia Shakitko
Re: Review Request 24969: [CLOUDSTACK-7398] SecurityGroupRule tags
cleanup on rule deletion
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24969/#review51275
-----------------------------------------------------------
Ship it!
Ship It!
- Wei Zhou
On 八月 22, 2014, 9:38 a.m., Ilia Shakitko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24969/
> -----------------------------------------------------------
>
> (Updated 八月 22, 2014, 9:38 a.m.)
>
>
> Review request for cloudstack, Abhishek Agarwal, Alena Prokharchyk, Animesh Chaturvedi, Abhinandan Prateek, Darren Shepherd, edison su, Kelven Yang, and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7398
> https://issues.apache.org/jira/browse/CLOUDSTACK-7398
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When deleting a SecurityGroup rule with some tags linked to it, tags are still being exist in DB. And they are linked to a non-existing resource now (since SG rule was deleted)
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/security/dao/SecurityGroupRuleDaoImpl.java 564ec08
>
> Diff: https://reviews.apache.org/r/24969/diff/
>
>
> Testing
> -------
>
> Tested on master branch (codebase 21st of August).
>
> 1) Created a SG rule
> 2) Created few tags for that rule
> 3) Deleted that rule and check listTags
> 4) Tags have also been deleted
>
>
> Thanks,
>
> Ilia Shakitko
>
>
Re: Review Request 24969: [CLOUDSTACK-7398] SecurityGroupRule tags
cleanup on rule deletion
Posted by Stephen Hoogendijk <st...@tca0.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24969/#review51273
-----------------------------------------------------------
Ship it!
Ship It!
- Stephen Hoogendijk
On Aug. 22, 2014, 9:38 a.m., Ilia Shakitko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24969/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 9:38 a.m.)
>
>
> Review request for cloudstack, Abhishek Agarwal, Alena Prokharchyk, Animesh Chaturvedi, Abhinandan Prateek, Darren Shepherd, edison su, Kelven Yang, and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7398
> https://issues.apache.org/jira/browse/CLOUDSTACK-7398
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When deleting a SecurityGroup rule with some tags linked to it, tags are still being exist in DB. And they are linked to a non-existing resource now (since SG rule was deleted)
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/security/dao/SecurityGroupRuleDaoImpl.java 564ec08
>
> Diff: https://reviews.apache.org/r/24969/diff/
>
>
> Testing
> -------
>
> Tested on master branch (codebase 21st of August).
>
> 1) Created a SG rule
> 2) Created few tags for that rule
> 3) Deleted that rule and check listTags
> 4) Tags have also been deleted
>
>
> Thanks,
>
> Ilia Shakitko
>
>
Re: Review Request 24969: [CLOUDSTACK-7398] SecurityGroupRule tags
cleanup on rule deletion
Posted by Ilia Shakitko <i....@tech.leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24969/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 9:38 a.m.)
Review request for cloudstack, Abhishek Agarwal, Alena Prokharchyk, Animesh Chaturvedi, Abhinandan Prateek, Darren Shepherd, edison su, Kelven Yang, and Wei Zhou.
Bugs: CLOUDSTACK-7398
https://issues.apache.org/jira/browse/CLOUDSTACK-7398
Repository: cloudstack-git
Description
-------
When deleting a SecurityGroup rule with some tags linked to it, tags are still being exist in DB. And they are linked to a non-existing resource now (since SG rule was deleted)
Diffs
-----
engine/schema/src/com/cloud/network/security/dao/SecurityGroupRuleDaoImpl.java 564ec08
Diff: https://reviews.apache.org/r/24969/diff/
Testing
-------
Tested on master branch (codebase 21st of August).
1) Created a SG rule
2) Created few tags for that rule
3) Deleted that rule and check listTags
4) Tags have also been deleted
Thanks,
Ilia Shakitko