You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Matei Zaharia <ma...@apache.org> on 2012/03/30 05:16:46 UTC
Review Request: Update protobuf to version 2.4.1 (MESOS-174)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4566/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Summary
-------
MESOS-174. Update protobuf version to 2.4.1.
For sanity, this patch includes everything except the actual change of third_party/protobuf-2.3.0 to third_party/protobuf-2.4.1, which is about 13 MB worth of files.
Diffs
-----
hadoop/TUTORIAL.sh a8fc67d
hadoop/hadoop-0.20.205.0.patch 670cf86
hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 017432a
src/examples/java/test-exception-framework.in 8f0efbe
src/examples/java/test-executor.in a323d16
src/examples/java/test-framework.in a664cbd
src/examples/java/test-multiple-executors-framework.in 1089add
src/examples/python/test-executor.in 309e874
src/examples/python/test-framework.in d16333c
src/python/setup.py.in a1190a6
src/tests/Makefile.in 6f51be4
Diff: https://reviews.apache.org/r/4566/diff
Testing
-------
make check, make hadoop, make install
Thanks,
Matei
Re: Review Request: Update protobuf to version 2.4.1 (MESOS-174)
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4566/#review6566
-----------------------------------------------------------
Ship it!
Cool, thanks.
- Benjamin
On 2012-03-30 03:16:46, Matei Zaharia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4566/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 03:16:46)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> MESOS-174. Update protobuf version to 2.4.1.
>
> For sanity, this patch includes everything except the actual change of third_party/protobuf-2.3.0 to third_party/protobuf-2.4.1, which is about 13 MB worth of files.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh a8fc67d
> hadoop/hadoop-0.20.205.0.patch 670cf86
> hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 017432a
> src/examples/java/test-exception-framework.in 8f0efbe
> src/examples/java/test-executor.in a323d16
> src/examples/java/test-framework.in a664cbd
> src/examples/java/test-multiple-executors-framework.in 1089add
> src/examples/python/test-executor.in 309e874
> src/examples/python/test-framework.in d16333c
> src/python/setup.py.in a1190a6
> src/tests/Makefile.in 6f51be4
>
> Diff: https://reviews.apache.org/r/4566/diff
>
>
> Testing
> -------
>
> make check, make hadoop, make install
>
>
> Thanks,
>
> Matei
>
>
Re: Review Request: Update protobuf to version 2.4.1 (MESOS-174)
Posted by Matei Zaharia <ma...@apache.org>.
> On 2012-03-30 04:59:41, Benjamin Hindman wrote:
> > src/tests/Makefile.in, line 55
> > <https://reviews.apache.org/r/4566/diff/1/?file=97519#file97519line55>
> >
> > This file should not be part of the repository!
Alright, wil remover it in the other patch.
- Matei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4566/#review6563
-----------------------------------------------------------
On 2012-03-30 03:16:46, Matei Zaharia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4566/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 03:16:46)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> MESOS-174. Update protobuf version to 2.4.1.
>
> For sanity, this patch includes everything except the actual change of third_party/protobuf-2.3.0 to third_party/protobuf-2.4.1, which is about 13 MB worth of files.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh a8fc67d
> hadoop/hadoop-0.20.205.0.patch 670cf86
> hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 017432a
> src/examples/java/test-exception-framework.in 8f0efbe
> src/examples/java/test-executor.in a323d16
> src/examples/java/test-framework.in a664cbd
> src/examples/java/test-multiple-executors-framework.in 1089add
> src/examples/python/test-executor.in 309e874
> src/examples/python/test-framework.in d16333c
> src/python/setup.py.in a1190a6
> src/tests/Makefile.in 6f51be4
>
> Diff: https://reviews.apache.org/r/4566/diff
>
>
> Testing
> -------
>
> make check, make hadoop, make install
>
>
> Thanks,
>
> Matei
>
>
Re: Review Request: Update protobuf to version 2.4.1 (MESOS-174)
Posted by Matei Zaharia <ma...@apache.org>.
> On 2012-03-30 04:59:41, Benjamin Hindman wrote:
> > I was expecting a change in third_party/versions.am ...
This is actually there, but I excluded third_party in the diff.
- Matei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4566/#review6563
-----------------------------------------------------------
On 2012-03-30 03:16:46, Matei Zaharia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4566/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 03:16:46)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> MESOS-174. Update protobuf version to 2.4.1.
>
> For sanity, this patch includes everything except the actual change of third_party/protobuf-2.3.0 to third_party/protobuf-2.4.1, which is about 13 MB worth of files.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh a8fc67d
> hadoop/hadoop-0.20.205.0.patch 670cf86
> hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 017432a
> src/examples/java/test-exception-framework.in 8f0efbe
> src/examples/java/test-executor.in a323d16
> src/examples/java/test-framework.in a664cbd
> src/examples/java/test-multiple-executors-framework.in 1089add
> src/examples/python/test-executor.in 309e874
> src/examples/python/test-framework.in d16333c
> src/python/setup.py.in a1190a6
> src/tests/Makefile.in 6f51be4
>
> Diff: https://reviews.apache.org/r/4566/diff
>
>
> Testing
> -------
>
> make check, make hadoop, make install
>
>
> Thanks,
>
> Matei
>
>
Re: Review Request: Update protobuf to version 2.4.1 (MESOS-174)
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4566/#review6563
-----------------------------------------------------------
I was expecting a change in third_party/versions.am ...
src/tests/Makefile.in
<https://reviews.apache.org/r/4566/#comment14246>
This file should not be part of the repository!
- Benjamin
On 2012-03-30 03:16:46, Matei Zaharia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4566/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 03:16:46)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> MESOS-174. Update protobuf version to 2.4.1.
>
> For sanity, this patch includes everything except the actual change of third_party/protobuf-2.3.0 to third_party/protobuf-2.4.1, which is about 13 MB worth of files.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh a8fc67d
> hadoop/hadoop-0.20.205.0.patch 670cf86
> hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 017432a
> src/examples/java/test-exception-framework.in 8f0efbe
> src/examples/java/test-executor.in a323d16
> src/examples/java/test-framework.in a664cbd
> src/examples/java/test-multiple-executors-framework.in 1089add
> src/examples/python/test-executor.in 309e874
> src/examples/python/test-framework.in d16333c
> src/python/setup.py.in a1190a6
> src/tests/Makefile.in 6f51be4
>
> Diff: https://reviews.apache.org/r/4566/diff
>
>
> Testing
> -------
>
> make check, make hadoop, make install
>
>
> Thanks,
>
> Matei
>
>