[GitHub] suxingfate commented on a change in pull request #23322: [SPARK-25922][K8] Spark Driver/Executor "spark-app-selector" label mismatch

[GitBox <gi...@apache.org>]

suxingfate commented on a change in pull request #23322: [SPARK-25922][K8] Spark Driver/Executor "spark-app-selector" label mismatch
URL: https://github.com/apache/spark/pull/23322#discussion_r241943139
 
 

 ##########
 File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
 ##########
 @@ -60,6 +61,16 @@ private[spark] class KubernetesClusterSchedulerBackend(
     removeExecutor(executorId, reason)
   }
 
+  /**
+    * Get an application ID associated with the job.
+    * This returns the string value of spark.app.id if set, otherwise
+    * the locally-generated ID from the superclass.
+    * @return The application ID
+    */
+  override def applicationId(): String = {
+    conf.getOption("spark.app.id").map(_.toString).getOrElse {super.applicationId}
 
 Review comment:
   updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org