You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "bcaw-ofeer (via GitHub)" <gi...@apache.org> on 2025/07/31 02:49:42 UTC
[PR] [ISSUE #1057] [Java] Enhance MessageImpl to allow subclasses to access properties [rocketmq-clients]
bcaw-ofeer opened a new pull request, #1058:
URL: https://github.com/apache/rocketmq-clients/pull/1058
<!-- Please make sure the target branch is right. In most case, the target branch should be `master`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #[1057](https://github.com/apache/rocketmq-clients/issues/1057)
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
1. Change MessageImpl.properties visibility from private to protected
2. Modify getProperties() to return Collections.unmodifiableMap(properties) instead of new HashMap<>(properties)
This change enables:
- Inheritance-based access to properties in subclasses
- Immutable view of properties to prevent external modifications
- Better performance by avoiding unnecessary HashMap allocations
- Maintains backward compatibility while improving extensibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #1057] [Java] Enhance MessageImpl to allow subclasses to access properties [rocketmq-clients]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1058:
URL: https://github.com/apache/rocketmq-clients/pull/1058#issuecomment-3149861468
## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/1058?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 53.07%. Comparing base ([`4076e2b`](https://app.codecov.io/gh/apache/rocketmq-clients/commit/4076e2b1d9979079c228aa52bfc8fa6dd874fa3b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dd91b4e`](https://app.codecov.io/gh/apache/rocketmq-clients/commit/dd91b4e74cc9164916d0aae6a5f4a3a1329fc8eb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 57 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1058 +/- ##
============================================
- Coverage 53.26% 53.07% -0.20%
- Complexity 651 662 +11
============================================
Files 208 211 +3
Lines 14303 14006 -297
Branches 5845 5536 -309
============================================
- Hits 7619 7434 -185
+ Misses 6308 6198 -110
+ Partials 376 374 -2
```
| [Flag](https://app.codecov.io/gh/apache/rocketmq-clients/pull/1058/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/rocketmq-clients/pull/1058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.79% <100.00%> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq-clients/pull/1058?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #1057] [Java] Enhance MessageImpl to allow subclasses to access properties [rocketmq-clients]
Posted by "bcaw-ofeer (via GitHub)" <gi...@apache.org>.
bcaw-ofeer closed pull request #1058: [ISSUE #1057] [Java] Enhance MessageImpl to allow subclasses to access properties
URL: https://github.com/apache/rocketmq-clients/pull/1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #1057] [Java] Enhance MessageImpl to allow subclasses to access properties [rocketmq-clients]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #1058:
URL: https://github.com/apache/rocketmq-clients/pull/1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org