You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Gwen Shapira <gs...@cloudera.com> on 2015/03/17 03:27:44 UTC
Review Request 32146: SQOOP-2169: Kafka integration test bug
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32146/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2169
https://issues.apache.org/jira/browse/SQOOP-2169
Repository: sqoop-sqoop2
Description
-------
Changing the validation code to compare sets and therefore be insensitive to order.
Diffs
-----
test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java a65d862
Diff: https://reviews.apache.org/r/32146/diff/
Testing
-------
Ran integration test
Thanks,
Gwen Shapira
Re: Review Request 32146: SQOOP-2169: Kafka integration test bug
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32146/
-----------------------------------------------------------
(Updated March 17, 2015, 3:04 a.m.)
Review request for Sqoop.
Changes
-------
updated based on Abe's comment
Bugs: SQOOP-2169
https://issues.apache.org/jira/browse/SQOOP-2169
Repository: sqoop-sqoop2
Description
-------
Changing the validation code to compare sets and therefore be insensitive to order.
Diffs (updated)
-----
test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java a65d862
Diff: https://reviews.apache.org/r/32146/diff/
Testing
-------
Ran integration test
Thanks,
Gwen Shapira
Re: Review Request 32146: SQOOP-2169: Kafka integration test bug
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32146/#review76702
-----------------------------------------------------------
Ship it!
Ship It!
- richard zhou
On March 17, 2015, 2:27 a.m., Gwen Shapira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32146/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 2:27 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2169
> https://issues.apache.org/jira/browse/SQOOP-2169
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Changing the validation code to compare sets and therefore be insensitive to order.
>
>
> Diffs
> -----
>
> test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java a65d862
>
> Diff: https://reviews.apache.org/r/32146/diff/
>
>
> Testing
> -------
>
> Ran integration test
>
>
> Thanks,
>
> Gwen Shapira
>
>
Re: Review Request 32146: SQOOP-2169: Kafka integration test bug
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32146/#review76701
-----------------------------------------------------------
Ship it!
Cool!
test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java
<https://reviews.apache.org/r/32146/#comment124330>
Assert.assertEquals might work?
- Abraham Elmahrek
On March 17, 2015, 2:27 a.m., Gwen Shapira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32146/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 2:27 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2169
> https://issues.apache.org/jira/browse/SQOOP-2169
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Changing the validation code to compare sets and therefore be insensitive to order.
>
>
> Diffs
> -----
>
> test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java a65d862
>
> Diff: https://reviews.apache.org/r/32146/diff/
>
>
> Testing
> -------
>
> Ran integration test
>
>
> Thanks,
>
> Gwen Shapira
>
>