[GitHub] [incubator-mxnet] leezu commented on issue #17968: [RFC] Raising the toolchain requirements for MXNet 2

[GitBox <gi...@apache.org>]

leezu commented on issue #17968: [RFC] Raising the toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/issues/17968#issuecomment-613681904
 
 
   https://github.com/apache/incubator-mxnet/commit/fb73a1717acad61caeaeef010faed9e9fcc05f0e implements the proposal, fixing a number of other issues that were blocking. Please see the commit message for a complete list of changes.
   
   As a follow-up item, I suggest to remove the `cpplint` we currently use in favor of `clang-tidy` (which we also use). cpplint enforces the Google's C++ style guide, which is geared toward C++03. Instead we can target https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines with enforcement by clang-tidy (+ potentially MSVC).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services