You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/04/29 06:20:52 UTC
Review Request 73310: ATLAS-4267 : Quick Search : AggregationMetrics
is incorrect with some special characters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-4267
https://issues.apache.org/jira/browse/ATLAS-4267
Repository: atlas
Description
-------
Quick search with attribute filter :
qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1." has empty AggregationMetrics
whereas with "default.datagen_table_sensitive_725_1" has right AggregationMetrics. __
Diffs
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java 1dd8be7e9
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 3750799f7
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java f55577c8c
Diff: https://reviews.apache.org/r/73310/diff/1/
Testing
-------
Unit test case added
Thanks,
Pinal Shah
Re: Review Request 73310: ATLAS-4267 : Quick Search :
AggregationMetrics is incorrect with some special characters
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/#review222907
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java
Line 351 (original), 392 (patched)
<https://reviews.apache.org/r/73310/#comment312078>
duuplicate lines 392/394 and 400/402:
consider replacing:
```
String attrValuePrefix = replaceWildCard ? ":*" : ":";
queryBuilder.append("+").append(indexFieldName).append(attrValuePrefix).append(attributeValue).append(" ");
```
- Sarath Subramanian
On April 29, 2021, 3:46 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73310/
> -----------------------------------------------------------
>
> (Updated April 29, 2021, 3:46 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4267
> https://issues.apache.org/jira/browse/ATLAS-4267
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Quick search with attribute filter :
>
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1." has empty AggregationMetrics
>
> whereas with "default.datagen_table_sensitive_725_1" has right AggregationMetrics. __
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java 1dd8be7e9
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java c2acc5b34
> repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 3750799f7
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java f55577c8c
>
>
> Diff: https://reviews.apache.org/r/73310/diff/2/
>
>
> Testing
> -------
>
> Unit test case added
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73310: ATLAS-4267 : Quick Search :
AggregationMetrics is incorrect with some special characters
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/#review222912
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On April 29, 2021, 10:09 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73310/
> -----------------------------------------------------------
>
> (Updated April 29, 2021, 10:09 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4267
> https://issues.apache.org/jira/browse/ATLAS-4267
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Quick search with attribute filter :
>
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1." has empty AggregationMetrics
>
> whereas with "default.datagen_table_sensitive_725_1" has right AggregationMetrics. __
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java 1dd8be7e9
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java c2acc5b34
> repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 3750799f7
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java f55577c8c
>
>
> Diff: https://reviews.apache.org/r/73310/diff/3/
>
>
> Testing
> -------
>
> Unit test case added
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73310: ATLAS-4267 : Quick Search :
AggregationMetrics is incorrect with some special characters
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/
-----------------------------------------------------------
(Updated April 29, 2021, 5:09 p.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
addressed review comments
Bugs: ATLAS-4267
https://issues.apache.org/jira/browse/ATLAS-4267
Repository: atlas
Description
-------
Quick search with attribute filter :
qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1." has empty AggregationMetrics
whereas with "default.datagen_table_sensitive_725_1" has right AggregationMetrics. __
Diffs (updated)
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java 1dd8be7e9
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java c2acc5b34
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 3750799f7
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java f55577c8c
Diff: https://reviews.apache.org/r/73310/diff/3/
Changes: https://reviews.apache.org/r/73310/diff/2-3/
Testing
-------
Unit test case added
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console
Thanks,
Pinal Shah
Re: Review Request 73310: ATLAS-4267 : Quick Search :
AggregationMetrics is incorrect with some special characters
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/
-----------------------------------------------------------
(Updated April 29, 2021, 10:46 a.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-4267
https://issues.apache.org/jira/browse/ATLAS-4267
Repository: atlas
Description
-------
Quick search with attribute filter :
qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1." has empty AggregationMetrics
whereas with "default.datagen_table_sensitive_725_1" has right AggregationMetrics. __
Diffs (updated)
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java 1dd8be7e9
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java c2acc5b34
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 3750799f7
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java f55577c8c
Diff: https://reviews.apache.org/r/73310/diff/2/
Changes: https://reviews.apache.org/r/73310/diff/1-2/
Testing (updated)
-------
Unit test case added
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console
Thanks,
Pinal Shah