[GitHub] [dubbo] eugene-andreev commented on a change in pull request #9062: Add JDK17 Support for Javaassist

[GitBox <gi...@apache.org>]

eugene-andreev commented on a change in pull request #9062:
URL: https://github.com/apache/dubbo/pull/9062#discussion_r730857512



##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/ClassGenerator.java
##########
@@ -337,7 +343,16 @@ public ClassPool getClassPool() {
                     }
                 }
             }
-            return mCtc.toClass(loader, pd);
+
+            try {
+                return mPool.toClass(mCtc, neighborClass, loader, pd);
+            } catch (Throwable t) {
+                if (!(t instanceof CannotCompileException)) {
+                    return mPool.toClass(mCtc, loader, pd);
+                } else {
+                    throw t;
+                }

Review comment:
       ```suggestion
                  throw t;
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org