You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/01/17 14:12:45 UTC

[GitHub] rymanluk commented on a change in pull request #741: nimble/host: Allow low interval on non-connectable advertising

rymanluk commented on a change in pull request #741: nimble/host: Allow low interval on non-connectable advertising
URL: https://github.com/apache/mynewt-core/pull/741#discussion_r162060449
 
 

 ##########
 File path: net/nimble/host/src/ble_hs_hci_cmd.c
 ##########
 @@ -173,13 +173,20 @@ ble_hs_hci_cmd_body_le_set_adv_params(const struct hci_adv_params *adv,
         return -1;
     }
 
+/* When build with nimBLE controller we know it is BT5 compliant so no need
+ * to limit non-connectable advertising interval
+ */
+#if MYNEWT_VAL(BLE_DEVICE)
 
 Review comment:
   Maybe we should test also for BSP since it will not apply for nrf51?
   For sure  it will work for MYNEWT_VAL(BSP_NRF52840)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services