You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2022/01/07 09:36:23 UTC

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18132


Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................

[rebalancer_tool] refactor on IgnoredTserversRunner

ClusterInfo::tservers_to_empty is not needed to be populated when
'BuildClusterInfo' called, we use it in two cases:
- print replica count about tservers_to_empty.
- get replicas running on tservers_to_empty (used in
IgnoredTserverRunner).
But 'BuildClusterInfo" could be called in many places.

This patch removed it from ClusterInfo so we could get the information
only when needed.

Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
---
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
4 files changed, 107 insertions(+), 80 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18132/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18132 )

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................


Patch Set 3: Verified+1

unrelated test failure in TimestampAdvancementITest.TestUpgradeFromOlderCorruptedData


-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 21 Jan 2022 07:04:26 +0000
Gerrit-HasComments: No

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18132 )

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18132/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18132/1//COMMIT_MSG@16
PS1, Line 16: when needed.
> I'm not sure I see this particular change in this PS.  Isn't ClusterInfo in
Yes, I forgot to update it.


http://gerrit.cloudera.org:8080/#/c/18132/1/src/kudu/tools/rebalancer_tool.cc
File src/kudu/tools/rebalancer_tool.cc:

http://gerrit.cloudera.org:8080/#/c/18132/1/src/kudu/tools/rebalancer_tool.cc@1402
PS1, Line 1402: empty
> nit: emptying
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 19 Jan 2022 04:14:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18132 )

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 21 Jan 2022 07:04:37 +0000
Gerrit-HasComments: No

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18132 )

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................

[rebalancer_tool] refactor on IgnoredTserversRunner

ClusterInfo::tservers_to_empty is not needed to be populated when
'BuildClusterInfo' called, we use it in two cases:
- print replica count about tservers_to_empty.
- get replicas running on tservers_to_empty (used in IgnoredTserverRunner).
But 'BuildClusterInfo" could be called in many places.

This patch removed it from ClusterInfo so we could get the information
only when needed.

Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Reviewed-on: http://gerrit.cloudera.org:8080/18132
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/rebalance/rebalance_algo.h
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
5 files changed, 106 insertions(+), 83 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18132

to look at the new patch set (#3).

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................

[rebalancer_tool] refactor on IgnoredTserversRunner

ClusterInfo::tservers_to_empty is not needed to be populated when
'BuildClusterInfo' called, we use it in two cases:
- print replica count about tservers_to_empty.
- get replicas running on tservers_to_empty (used in IgnoredTserverRunner).
But 'BuildClusterInfo" could be called in many places.

This patch removed it from ClusterInfo so we could get the information
only when needed.

Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
---
M src/kudu/rebalance/rebalance_algo.h
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
5 files changed, 106 insertions(+), 83 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18132/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18132 )

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18132/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18132/1//COMMIT_MSG@16
PS1, Line 16: patch removed it from ClusterInfo
I'm not sure I see this particular change in this PS.  Isn't ClusterInfo in rebalance_algo.h supposed to be updated if doing so?


http://gerrit.cloudera.org:8080/#/c/18132/1/src/kudu/tools/rebalancer_tool.cc
File src/kudu/tools/rebalancer_tool.cc:

http://gerrit.cloudera.org:8080/#/c/18132/1/src/kudu/tools/rebalancer_tool.cc@1402
PS1, Line 1402: empty
nit: emptying



-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Jan 2022 18:57:27 +0000
Gerrit-HasComments: Yes

[kudu-CR] [rebalancer tool] refactor on IgnoredTserversRunner

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18132

to look at the new patch set (#2).

Change subject: [rebalancer_tool] refactor on IgnoredTserversRunner
......................................................................

[rebalancer_tool] refactor on IgnoredTserversRunner

ClusterInfo::tservers_to_empty is not needed to be populated when
'BuildClusterInfo' called, we use it in two cases:
- print replica count about tservers_to_empty.
- get replicas running on tservers_to_empty (used in IgnoredTserverRunner).
But 'BuildClusterInfo" could be called in many places.

This patch removed it from ClusterInfo so we could get the information
only when needed.

Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
---
M src/kudu/rebalance/rebalance_algo.h
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
5 files changed, 106 insertions(+), 83 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18132/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e51349d12fffb54458142169b9e7789c8d3987c
Gerrit-Change-Number: 18132
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)