You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Rakesh R (JIRA)" <ji...@apache.org> on 2014/06/02 12:07:02 UTC
[jira] [Commented] (BOOKKEEPER-582) Make bookie and client use
protobuf for requests (non-wire part)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015296#comment-14015296 ]
Rakesh R commented on BOOKKEEPER-582:
-------------------------------------
+1 from me. Since this a major improvement, it would be great to see feedback from [~fpj] too. Thanks!
I referred org.apache.bookkeeper.test.TestBackwardCompat.java. Also, please include few more compatibility test cases:
# where 4.2.0 client is talking to the new server.
# new client talking to 4.2.0 server
# include test case where client see "@return null if the statuscode is unknown." PerChannelBookieClient#statusCodeToExceptionCode(StatusCode status)
> Make bookie and client use protobuf for requests (non-wire part)
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-582
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-582
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, 0003-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, BOOKKEEPER-582.diff, BOOKKEEPER-582.v2.diff, BOOKKEEPER-582.v3.diff
>
>
> Make the client and the bookie use protobufs internally. This is the first step to using protobufs on the wire, but for the moment, BookieRequestHandler decodes the old wire protocol into the protobuf messages. Once this is in, enabling on the wire will be very simple, and the old manual serialization can be made "legacy" (still supported, but deprecated).
--
This message was sent by Atlassian JIRA
(v6.2#6252)