You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/04 14:06:28 UTC

Review Request 38119: Add metrics of messages_quiesce_offers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38119/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add metrics of messages_quiesce_offers


Diffs
-----

  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 
  src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 

Diff: https://reviews.apache.org/r/38119/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38119: Add metrics of messages_quiesce_offers

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38119/
-----------------------------------------------------------

(Updated 九月 18, 2015, 3:55 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add metrics of messages_quiesce_offers


Diffs (updated)
-----

  src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
  src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 
  src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 
  src/tests/master_tests.cpp 06d74c39b9a1674d2809b13c02eae757ba75b58c 
  src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 

Diff: https://reviews.apache.org/r/38119/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38119: Add metrics of messages_quiesce_offers

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38119/
-----------------------------------------------------------

(Updated 九月 16, 2015, 5:50 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add metrics of messages_quiesce_offers


Diffs (updated)
-----

  src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
  src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 
  src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 
  src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b 
  src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 

Diff: https://reviews.apache.org/r/38119/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38119: Add metrics of messages_quiesce_offers

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38119/#review99070
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38119/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add metrics of messages_quiesce_offers
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 
>   src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 
> 
> Diff: https://reviews.apache.org/r/38119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>