You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/28 18:23:41 UTC
[GitHub] [superset] justinpark opened a new pull request, #21968: fix: invalid float number format by json-bigint
justinpark opened a new pull request, #21968:
URL: https://github.com/apache/superset/pull/21968
### SUMMARY
This commit fixes the regression from #21937
There's [a known issue](https://github.com/sidorares/json-bigint/issues/74#issuecomment-1284992714) for floating value formatting on current latest version of `json-bigint` open source.
Since the main contributor no longer maintain the new release, this commit replaces the open-source library by `json-bigint-native` which is branched out from `json-bigint` and fixes the known bugs including float value issue.
This commit also adds the extra specs to verify the floating value formatting.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="395" alt="Screen Shot 2022-10-28 at 11 22 12 AM" src="https://user-images.githubusercontent.com/1392866/198705963-0409fdfa-f633-44fa-9490-de932e74c498.png">
After:
<img width="468" alt="Screen Shot 2022-10-28 at 11 22 18 AM" src="https://user-images.githubusercontent.com/1392866/198705989-0c6009d1-3911-4dc3-9f4e-b20a1cd4467b.png">
### TESTING INSTRUCTIONS
Create a chart with floating numbers
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
justinpark commented on PR #21968:
URL: https://github.com/apache/superset/pull/21968#issuecomment-1295340835
cc: @zhaoyongjie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
ktmud commented on PR #21968:
URL: https://github.com/apache/superset/pull/21968#issuecomment-1295422983
Can you add a link to the forked repo and npm package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #21968:
URL: https://github.com/apache/superset/pull/21968#discussion_r1009017298
##########
superset-frontend/package.json:
##########
@@ -145,6 +145,7 @@
"js-levenshtein": "^1.1.6",
"js-yaml-loader": "^1.2.2",
"json-bigint": "^1.0.0",
+ "json-bigint-native": "^1.2.0",
Review Comment:
the line [43](https://github.com/apache/superset/blob/2a852477943f588bfff6ac9dd0452bb9981bb93a/superset-frontend/packages/superset-ui-core/package.json#L43) also need to be removed.
##########
superset-frontend/package.json:
##########
@@ -145,6 +145,7 @@
"js-levenshtein": "^1.1.6",
"js-yaml-loader": "^1.2.2",
"json-bigint": "^1.0.0",
+ "json-bigint-native": "^1.2.0",
Review Comment:
The line [43](https://github.com/apache/superset/blob/2a852477943f588bfff6ac9dd0452bb9981bb93a/superset-frontend/packages/superset-ui-core/package.json#L43) also need to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21968:
URL: https://github.com/apache/superset/pull/21968#issuecomment-1295373426
# [Codecov](https://codecov.io/gh/apache/superset/pull/21968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21968](https://codecov.io/gh/apache/superset/pull/21968?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a85247) into [master](https://codecov.io/gh/apache/superset/commit/7f563cf92df82ab49590407adf6a7bce3eef1779?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f563cf) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21968 +/- ##
=======================================
Coverage 66.96% 66.96%
=======================================
Files 1807 1807
Lines 69221 69221
Branches 7402 7402
=======================================
Hits 46352 46352
Misses 20964 20964
Partials 1905 1905
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.39% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-core/src/connection/callApi/parseResponse.ts](https://codecov.io/gh/apache/superset/pull/21968/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29ubmVjdGlvbi9jYWxsQXBpL3BhcnNlUmVzcG9uc2UudHM=) | `100.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on a diff in pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
justinpark commented on code in PR #21968:
URL: https://github.com/apache/superset/pull/21968#discussion_r1009556421
##########
superset-frontend/package.json:
##########
@@ -145,6 +145,7 @@
"js-levenshtein": "^1.1.6",
"js-yaml-loader": "^1.2.2",
"json-bigint": "^1.0.0",
+ "json-bigint-native": "^1.2.0",
Review Comment:
will follow up with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #21968:
URL: https://github.com/apache/superset/pull/21968#discussion_r1008814115
##########
superset-frontend/package.json:
##########
@@ -145,6 +145,7 @@
"js-levenshtein": "^1.1.6",
"js-yaml-loader": "^1.2.2",
"json-bigint": "^1.0.0",
+ "json-bigint-native": "^1.2.0",
Review Comment:
If `json-bigint` is no longer maintained, can we remove that dep (on line 147)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #21968:
URL: https://github.com/apache/superset/pull/21968#discussion_r1009017298
##########
superset-frontend/package.json:
##########
@@ -145,6 +145,7 @@
"js-levenshtein": "^1.1.6",
"js-yaml-loader": "^1.2.2",
"json-bigint": "^1.0.0",
+ "json-bigint-native": "^1.2.0",
Review Comment:
Since the [json-bigint-native](https://www.npmjs.com/package/json-bigint-native) says that _added TypeScript types_, the line [43](https://github.com/apache/superset/blob/2a852477943f588bfff6ac9dd0452bb9981bb93a/superset-frontend/packages/superset-ui-core/package.json#L43) also need to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
justinpark commented on PR #21968:
URL: https://github.com/apache/superset/pull/21968#issuecomment-1295425098
> Can you add a link to the forked repo and npm package?
npm package: https://www.npmjs.com/package/json-bigint-native
repo: https://github.com/vogievetsky/json-bigint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #21968: fix: invalid float number format by json-bigint
Posted by GitBox <gi...@apache.org>.
john-bodley merged PR #21968:
URL: https://github.com/apache/superset/pull/21968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org