You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Shilun Fan (Jira)" <ji...@apache.org> on 2024/01/05 10:41:00 UTC

[jira] [Resolved] (HDFS-17309) RBF: Fix Router Safemode check contidition error

     [ https://issues.apache.org/jira/browse/HDFS-17309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shilun Fan resolved HDFS-17309.
-------------------------------
       Fix Version/s: 3.4.0
        Hadoop Flags: Reviewed
    Target Version/s: 3.3.6, 3.4.0
          Resolution: Fixed

> RBF: Fix Router Safemode check contidition error
> ------------------------------------------------
>
>                 Key: HDFS-17309
>                 URL: https://issues.apache.org/jira/browse/HDFS-17309
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: liuguanghua
>            Assignee: liuguanghua
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> With HDFS-17116, Router safemode check contidition use monotonicNow(). 
> For code in  RouterSafemodeService.periodicInvoke()
> long now = monotonicNow();
> long cacheUpdateTime = stateStore.getCacheUpdateTime();
> boolean isCacheStale = (now - cacheUpdateTime) > this.staleInterval;
>  
> Function monotonicNow() is implemented with System.nanoTime(). 
> System.nanoTime() in javadoc description:
> This method can only be used to measure elapsed time and is not related to any other notion of system or wall-clock time. The value returned represents nanoseconds since some fixed but arbitrary origin time (perhaps in the future, so values may be negative). 
>  
> The following situation maybe exists :
> If refreshCaches not success in the beginning, cacheUpdateTime will be 0 , and now - cacheUpdateTime is arbitrary origin time,so isCacheStale maybe  be true or false. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org