[jira] [Commented] (GEODE-9630) Gateway sender has public setter methods that should not be exposed

["Owen Nichols (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424751#comment-17424751 ] 

Owen Nichols commented on GEODE-9630:
-------------------------------------

1.14.0 had 0 setters in the GatewaySender interface

1.15.0 currently has 5 (was 6 but GEODE-9629 removed one of them):
  void setAlertThreshold(int alertThreshold);
  void setBatchSize(int batchSize);
  void setBatchTimeInterval(int batchTimeInterval);
  void setGroupTransactionEvents(boolean groupTransactionEvents);
  void setGatewayEventFilters(List<GatewayEventFilter> filters);

> Gateway sender has public setter methods that should not be exposed
> -------------------------------------------------------------------
>
>                 Key: GEODE-9630
>                 URL: https://issues.apache.org/jira/browse/GEODE-9630
>             Project: Geode
>          Issue Type: Improvement
>          Components: wan
>    Affects Versions: 1.15.0
>            Reporter: Udo Kohlmeyer
>            Priority: Blocker
>              Labels: needsTriage
>
> Looking at the GatewaySender interface I noticed there are numerous public setter methods. Geode should not allow for the ability to directly change GatewaySender functionality without proper process.
> This is largely to avoid the introduction of side effects into the system. A prime example of this is, the ability to call `setGroupTransactionEvents`, which from what I understand should NEVER be allowed to be changed in just 1 server instead of cluster-wide. This by writing a function and changing the setting on only 1 server can run the risk of the whole system behaving incorrectly causing failures which would be close to impossible to track down.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)