You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/04/26 02:15:14 UTC
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #4402: AWS: Add table level S3 tags
jackye1995 commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r858174866
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -357,6 +388,18 @@ public class AwsProperties implements Serializable {
*/
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
+ /**
+ * Used by {@link GlueCatalog}.
+ * The table name is used as part of table specific catalog properties.
Review Comment:
nit: as a part of
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -357,6 +388,18 @@ public class AwsProperties implements Serializable {
*/
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
+ /**
+ * Used by {@link GlueCatalog}.
+ * The table name is used as part of table specific catalog properties.
+ */
+ public static final String TABLE_NAME = "table-name";
+
+ /**
+ * Used by {@link GlueCatalog}.
+ * The database name is used as part of table specific catalog properties.
Review Comment:
nit: as a part of
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org