You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/15 06:53:26 UTC

[GitHub] [incubator-echarts] CarterLi opened a new pull request #13284: feat(TooltipView): provide a way to set the customized tooltip renderer

CarterLi opened a new pull request #13284:
URL: https://github.com/apache/incubator-echarts/pull/13284


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   Provide a way to set the customized tooltip renderer
   
   ### Fixed issues
   
   N/A
   
   
   ## Details
   
   ### Before: What was the problem?
   
   The tooltip renderer is hardcoded in repo and no way to override. For people using web worker ( or WX小程序 maybe? ) they have to use `TooltipRichContent` which has limitations compared to the default html renderer.
   
   
   
   ### After: How is it fixed in this PR?
   
   The PR provides a new option `renderer` for `tooltip`, and use it if set.
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [x] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   ```
   tooltip: {
     renderer: Constructor
   }
   ```
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13284: feat(TooltipView): provide a way to set the customized tooltip renderer

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13284:
URL: https://github.com/apache/incubator-echarts/pull/13284#issuecomment-692506629


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   Document changes are required in this PR. Please also make a PR to [apache/incubator-echarts-doc](https://github.com/apache/incubator-echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] CarterLi commented on pull request #13284: feat(TooltipView): provide a way to set the customized tooltip renderer

Posted by GitBox <gi...@apache.org>.
CarterLi commented on pull request #13284:
URL: https://github.com/apache/incubator-echarts/pull/13284#issuecomment-692507829


   Usage: https://github.com/CarterLi/echarts-with-offscreencanvas/blob/82cf09b40f8ceb373212e81f7b28b63508eee619/src/renderer.worker.ts#L9


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org