[jira] [Commented] (BEAM-191) Remove WindowedValue.valueInEmptyWindows

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358288#comment-15358288 ] 

ASF GitHub Bot commented on BEAM-191:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/523


> Remove WindowedValue.valueInEmptyWindows
> ----------------------------------------
>
>                 Key: BEAM-191
>                 URL: https://issues.apache.org/jira/browse/BEAM-191
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Minor
>              Labels: windowing
>
> Even though it is acceptable to create a WindowedValue carrying no windows when it is a fully reified WindowedValue<T>, it doesn't really make sense: When it becomes an element in a PCollection that a value must exist within some window.
> This has led to some confusion so we should remove the API. It seems there are just 11 files that reference WindowedValue.valueInEmptyWindows [1] that mostly look like they'd be fine with the global window.
> [1] https://github.com/apache/incubator-beam/search?p=1&q=valueInEmptyWindows&utf8=%E2%9C%93



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)