You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/04/05 16:20:58 UTC
[jira] Created: (MNG-3503) Shade MX* classes from plexus-utils
Shade MX* classes from plexus-utils
-----------------------------------
Key: MNG-3503
URL: http://jira.codehaus.org/browse/MNG-3503
Project: Maven 2
Issue Type: Improvement
Affects Versions: 2.0.8
Reporter: Benjamin Bentmann
Priority: Minor
Attachments: shade-mx-classes.patch
The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey reopened MNG-3503:
-----------------------------
Assignee: Benjamin Bentmann (was: John Casey)
When building a POM project with a site descriptor, this change causes a linkage error on XmlSerializer (from Xpp3Dom). Looking around on the java forums, I found this:
http://forum.java.sun.com/thread.jspa?messageID=3902289
which seems to hint that processing the Xpp3Dom class to change package names for anything at all might cause this problem. I'm not entirely sure I understand this problem, but I'm adding a new IT to the core-integration-tests to check this scenario for future changes.
Unfortunately, this issue won't make it into 2.0.10 as a result. This problem seems to indicate a level of risk for this change that I'm simply uncomfortable with at this stage.
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Assignee: Benjamin Bentmann
> Priority: Minor
> Fix For: 2.0.11
>
> Attachments: shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3503:
-----------------------------------
Attachment: shade-mx-classes-addon.patch
Adding the attached patch makes the IT pass for me (both with Shade 1.0.1 and 1.2-SNAPSHOT).
As described on the [dev@|http://www.nabble.com/Re%3A-svn-commit%3A-r677112----maven-components-branches-maven-2.0.10-RC-pom.xml-p18492787.html], once we refine the exclusions, the Shade Plugin will cause damage to the package imports in {{DefaultPluginManager}}. Refining these imports, too, seems functional.
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Assignee: Benjamin Bentmann
> Priority: Minor
> Fix For: 2.0.11
>
> Attachments: shade-mx-classes-addon.patch, shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3503:
-----------------------------------
Fix Version/s: 2.0.10
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Priority: Minor
> Fix For: 2.0.10
>
> Attachments: shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MNG-3503.
---------------------------
Assignee: John Casey
Resolution: Fixed
Fix Version/s: 2.1-alpha-1
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Assignee: John Casey
> Priority: Minor
> Fix For: 2.0.10, 2.1-alpha-1
>
> Attachments: shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3503:
-----------------------------------
Fix Version/s: 3.0-alpha-1
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Assignee: Brett Porter
> Priority: Minor
> Fix For: 2.0.10, 2.1.0-M2, 3.0-alpha-1
>
> Attachments: shade-mx-classes-addon.patch, shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MNG-3503:
----------------------------
Fix Version/s: (was: 2.0.11)
2.0.10
I'll try to get this in too.
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Priority: Minor
> Fix For: 2.0.10
>
> Attachments: shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MNG-3503:
----------------------------
Fix Version/s: (was: 2.0.10)
(was: 2.1-alpha-1)
2.0.11
pushing to 2.0.11, and I'll revert this change in trunk until we have a solution.
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Assignee: Benjamin Bentmann
> Priority: Minor
> Fix For: 2.0.11
>
> Attachments: shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3503) Shade MX* classes from plexus-utils
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MNG-3503.
-----------------------------
Assignee: Brett Porter (was: Benjamin Bentmann)
Resolution: Fixed
Fix Version/s: (was: 2.0.11)
2.1.0-M2
2.0.10
reapplied to 2.0.10, and rewrote the integration test to both verify the original fix, and a more specific test for the linkage error that was being seen rather than just using the site plugin
> Shade MX* classes from plexus-utils
> -----------------------------------
>
> Key: MNG-3503
> URL: http://jira.codehaus.org/browse/MNG-3503
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Benjamin Bentmann
> Assignee: Brett Porter
> Priority: Minor
> Fix For: 2.0.10, 2.1.0-M2
>
> Attachments: shade-mx-classes-addon.patch, shade-mx-classes.patch
>
>
> The Maven uber JAR currently ships with unshaded {{MXParser}} and {{MXSerializer}}, preventing plugins from using their recent implementations from plexus-utils. My initial question on the [dev list|http://www.nabble.com/Shade-MX*-classes-from-plexus-utils--tc16080800s177.html] showed now immediate objections and the core ITs also smile so here we go with the proposed patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira