[jira] [Commented] (GEODE-8559) A race could occur during interest registration combined with transactional operations

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205145#comment-17205145 ] 

ASF GitHub Bot commented on GEODE-8559:
---------------------------------------

pivotal-eshu opened a new pull request #5581:
URL: https://github.com/apache/geode/pull/5581


     * Compute interest routing info after transactional event has been
       applied to cache. This will make sure an interested client will
       either get the event through region snapshot taken or through
       HARegionQueue.
     * Add test coverage for CQ with transactional destroy event to make
       sure CQ routing is computed correctly.
     * Remove sleep in exiting test code.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> A race could occur during interest registration combined with transactional operations
> --------------------------------------------------------------------------------------
>
>                 Key: GEODE-8559
>                 URL: https://issues.apache.org/jira/browse/GEODE-8559
>             Project: Geode
>          Issue Type: Bug
>          Components: client queues, transactions
>    Affects Versions: 1.1.0
>            Reporter: Eric Shu
>            Assignee: Eric Shu
>            Priority: Major
>
> During client interest registration, a region snapshot is taken from server and entry operations after the registration should be sent to client via Region queue.
> There is a race in transaction implementation. Interested client computation is occurred before the transactional operations is applied to the cache during commit. This could lead to client does not get the operations through region snapshot taken, and the transactional operation is not being sent to the client (as the interested clients were computed before hand.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)