You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2025/08/08 17:06:06 UTC
[I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
dlmarion opened a new issue, #5787:
URL: https://github.com/apache/accumulo/issues/5787
```
[ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 121.0 s <<< FAILURE! -- in org.apache.accumulo.test.fate.user.UserFatePoolsWatcherIT_SimpleSuite
[ERROR] org.apache.accumulo.test.fate.user.UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 -- Time elapsed: 63.73 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
at org.apache.accumulo.test.fate.FatePoolsWatcherITBase.testIncrease1(FatePoolsWatcherITBase.java:179)
at org.apache.accumulo.test.fate.user.UserFatePoolsWatcherIT_SimpleSuite.executeTest(UserFatePoolsWatcherIT_SimpleSuite.java:56)
at org.apache.accumulo.test.fate.FateTestRunner.executeTest(FateTestRunner.java:33)
at org.apache.accumulo.test.fate.FatePoolsWatcherITBase.testIncrease1(FatePoolsWatcherITBase.java:73)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on issue #5787:
URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3168947454
I put up a PR that may improve the error messages that come out of these ITs: #5790
It does not fix any of the test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on issue #5787:
URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3192218803
I'll look into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #5787:
URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3168735656
Found that when this fails it's due to the Fate not shutting down. The following is in the log:
```
2025-08-08T12:18:33,788 133 [fate.FateExecutor] WARN : Waited for 60021ms for the USER fate executor operating on fate ops [TABLE_CREATE, TABLE_DELETE, TABLE_DELETE_RANGE, TABLE_EXPORT, TABLE_IMPORT, TABLE_MERGE
, TABLE_OFFLINE, TABLE_ONLINE, TABLE_RENAME, TABLE_SPLIT, TABLE_TABLET_AVAILABILITY] to stop, but it is still running. Summary of run state of its threads: work finder:false transaction executor:true
2025-08-08T12:18:33,788 133 [fate.Fate] WARN : Waited for 60022ms for all fate USER background threads to stop, but some are still running. fate executor threads:true dead reservation cleaner thread:false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #5787:
URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3168738810
I think I found the problem, but I'm not sure how to fix it. I think the `FatePoolsWatcherITBase.testIncrease1` has some issues. First, each test method has a variable `allAssertsOccurred` that is used in the `finally` block to check that each assertion was checked. I don't think this is necessary and it hides the actual error that causes the test to fail. Second issue, which I'm not quite sure how to fix at this point, is that `PoolResizeTestRepo.isReady` waits on a latch indefinitely. In `testIncrease1` the configuration is changed which is supposed to shutdown the FateExecutor running the transactions. But the Fate transactions are blocked on the latch and don't shut down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner closed issue #5787: Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1
URL: https://github.com/apache/accumulo/issues/5787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #5787:
URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3168910560
For the issue w/ `PoolResizeTestRepo.isReady` we could signael the test is done somehow and get it to exit.
```diff
diff --git a/test/src/main/java/org/apache/accumulo/test/fate/FatePoolsWatcherITBase.java b/test/src/main/java/org/apache/accumulo/test/fate/FatePoolsWatcherITBase.java
index 871c14e2cb..2ae14c9461 100644
--- a/test/src/main/java/org/apache/accumulo/test/fate/FatePoolsWatcherITBase.java
+++ b/test/src/main/java/org/apache/accumulo/test/fate/FatePoolsWatcherITBase.java
@@ -687,7 +687,11 @@ public abstract class FatePoolsWatcherITBase extends SharedMiniClusterBase
@Override
public long isReady(FateId fateId, PoolResizeTestEnv environment) throws Exception {
environment.numWorkers.incrementAndGet();
- environment.isReadyLatch.await();
+ while(!environment.isReadyLatch.await(10, TimeUnit.MILLISECONDS)){
+ if(testIsDone){
+ // TODO exit or throw exception?
+ }
+ }
return 0;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on issue #5787:
URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3180135102
I wrote this test, so I can look into this sometime soon unless a fix is made before then (in which case I can review the PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Broken test: UserFatePoolsWatcherIT_SimpleSuite.testIncrease1 [accumulo]
Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on issue #5787:
URL: https://github.com/apache/accumulo/issues/5787#issuecomment-3192306549
> I think the FatePoolsWatcherITBase.testIncrease1 has some issues. First, each test method has a variable allAssertsOccurred that is used in the finally block to check that each assertion was checked. I don't think this is necessary and it hides the actual error that causes the test to fail.
@DomGarguilo fixed this with https://github.com/apache/accumulo/pull/5790
> Second issue, which I'm not quite sure how to fix at this point, is that PoolResizeTestRepo.isReady waits on a latch indefinitely. In testIncrease1 the configuration is changed which is supposed to shutdown the FateExecutor running the transactions. But the Fate transactions are blocked on the latch and don't shut down.
This is intended and not an issue, this is to test that transaction runners are not stopped in the middle of executing a fate op when a shutdown/config change occurs. See this check:
```
// The FateExecutor assigned to SET2 is no longer valid after the config change, so a
// shutdown should be initiated and all the runners but the one working on a transaction
// should be stopped.
assertEquals(1, fate.getTxRunnersActive(set2));
```
We later allow the work to complete and the shutdown to finish with
```
// finish work
env.isReadyLatch.countDown();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org