You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/11/22 15:23:20 UTC
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #349: [ISSUE-364] Fix `indexWriter` don't close if exception thrown when close dataWriter
codecov-commenter commented on PR #349:
URL: https://github.com/apache/incubator-uniffle/pull/349#issuecomment-1323847128
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/349?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#349](https://codecov.io/gh/apache/incubator-uniffle/pull/349?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59a96cb) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/5b5acb5f3bcf8e12cc42612754d325aca4e3b991?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b5acb5) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #349 +/- ##
============================================
+ Coverage 58.40% 58.42% +0.01%
Complexity 1554 1554
============================================
Files 193 193
Lines 10763 10758 -5
Branches 937 935 -2
============================================
- Hits 6286 6285 -1
+ Misses 4104 4102 -2
+ Partials 373 371 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../storage/handler/impl/HdfsShuffleWriteHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9IZGZzU2h1ZmZsZVdyaXRlSGFuZGxlci5qYXZh) | `87.09% <100.00%> (+2.02%)` | :arrow_up: |
| [...a/org/apache/uniffle/coordinator/QuotaManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvUXVvdGFNYW5hZ2VyLmphdmE=) | `88.63% <0.00%> (+4.54%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org